-
Notifications
You must be signed in to change notification settings - Fork 29
Open
Labels
area:coreA bug/feature for the core code-input.js/code-input.css filesA bug/feature for the core code-input.js/code-input.css filesbreaking-changebugSomething isn't workingSomething isn't workingpriority:high
Milestone
Description
Key events used in plugins are not always the best choices. For example, keydown
is listened to for enter key presses to create newlines in the indent plugin, but beforeinput
or input
would be better and allow for external code to intercept enter key presses differently with preventDefault. The code for this is here and used for Ctrl+Enter functionality here.
This is a breaking change which would interfere with code using the library and other plugins, but would allow functionality otherwise impossible.
Metadata
Metadata
Assignees
Labels
area:coreA bug/feature for the core code-input.js/code-input.css filesA bug/feature for the core code-input.js/code-input.css filesbreaking-changebugSomething isn't workingSomething isn't workingpriority:high