Rename Syntax module to Ast #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
Oh, can you also adjust the README to reflect the name change? |
|
Sorry, I was in the air for the rest of the day after submitting the PR. Looks like you already did the readme.md changes. |
dhil
pushed a commit
to dhil/webassembly-spec
that referenced
this pull request
Apr 26, 2018
eqrion
pushed a commit
to eqrion/wasm-spec
that referenced
this pull request
Jul 18, 2019
Also remove some of the stuff from the bulk memory proposal that really should be written in the spec ReST files.
ErikMcClure
pushed a commit
to innative-sdk/spec
that referenced
this pull request
May 28, 2020
alexcrichton
pushed a commit
to alexcrichton/spec
that referenced
this pull request
Jul 28, 2020
Fix typo in instance type example
dhil
added a commit
to dhil/webassembly-spec
that referenced
this pull request
Mar 2, 2023
Add cont type and instructions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have a very strong preference, but "Syntax" makes me think of concrete syntax, as in S-Exprs. How about renaming the module to Ast, so there is a clear correspondence with design/AstSemantics.md?