Add a test of block label redefinition. #216
Conversation
| (func $redefinition (result i32) | ||
| (block $l1 | ||
| (i32.add (block $l1 | ||
| (i32.const 2)) |
There was a problem hiding this comment.
There is no style guide for the formatting of s-exp. Putting trailing braces on separate lines is what I see beginners do and once people have a little experience they prefer the increased information density of placing them on one line - you will not find experienced lisp codes putting closing braces on separate lines as a style rule (there are some exceptions, but not for something so simple as above).
There was a problem hiding this comment.
I was referring to the inconsistent indentation and the extra line breaks in particular. That said, it's good practice for changes to adapt to surrounding styles. ;)
|
lgtm |
|
This branch needs a merge conflict resolution. |
|
Ping @JSStats, can you resolve the merge conflict? |
|
ptal |
Add a test of block label redefinition.
ghost
deleted the
Fixes WebAssembly#215. This should indicate that an engine is still conforming if it does not attach a stack trace, even if `traceStack` is requested by JavaScript code (by setting it to `true`).
To resolve #210