Skip to content

[spec] Remove vestigial prime symbol in data segment text format #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2025

Conversation

keithw
Copy link
Member

@keithw keithw commented Jun 6, 2025

Pre-2018, the spec for the text format defined data and element segments as having an implicit "table 0" or "memory 0" with mathematical notation with an 𝑥′ that takes the value 0 if the memidx wasn't present in the text format.

#752 (responding to WebAssembly/reference-types#3 (comment)) removed the definitions of x' and instead defined a text-format abbreviation for data and elem segments, e.g.:

Also, the memory index can be omitted, defaulting to 0.
‘(’ ‘data’ ‘(’ ‘offset’ expr𝐼 ‘)’ . . . ‘)’ ≡ ‘(’ ‘data’ 0 ‘(’ ‘offset’ expr𝐼 ‘)’ . . . ‘)’

However, that commit only removed the prime symbol (from 𝑥′ ) for the production for element segments but kept it in for data segments. This commit removes the vestigial prime from 𝑥′ for data segments.

Copy link
Member

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rossberg rossberg merged commit a0a8df7 into WebAssembly:wasm-3.0 Jun 6, 2025
10 of 11 checks passed
@keithw keithw deleted the wasm-3.0-prime branch June 6, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants