Skip to content

[spec] Normative: Permit work in parallel during instantiation #1606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

tomstuart
Copy link
Contributor

This is a recreation of @littledan’s #745, which was erroneously merged into master instead of main because it’s five years old.

Copy link
Collaborator

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, thanks for pointing that out.

JSC will have to do asynchronous compilation work during some instantiations.
To be consistent, this PR always queues a task to complete instantiation,
except through the synchronous Instance(module) API, to ensure consistency
across platforms.

This patch also cleans up the specification in various surrounding ways:
- Include notes about APIs whose use is discouraged/may be limited

Closes WebAssembly#741
See also webpack/webpack#6433
@Ms2ger Ms2ger force-pushed the littledan-queueing branch from 699ce94 to b68d53e Compare February 21, 2023 10:57
@Ms2ger Ms2ger merged commit 25b3df3 into WebAssembly:main Feb 21, 2023
@tomstuart tomstuart deleted the littledan-queueing branch February 21, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants