Skip to content

[spec] Fix oversight in reversal of br_table validation #1305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions document/core/valid/instructions.rst
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ and the provided output stack with result values of types :math:`t_2^\ast` that
Stack types are akin to :ref:`function types <syntax-functype>`,
except that they allow individual operands to be classified as :math:`\bot` (*bottom*), indicating that the type is unconstrained.
As an auxiliary notion, an operand type :math:`t_1` *matches* another operand type :math:`t_2`, if :math:`t_1` is either :math:`\bot` or equal to :math:`t_2`.
This is extended to stack types in a point-wise manner.

.. _match-opdtype:

Expand All @@ -35,6 +36,13 @@ As an auxiliary notion, an operand type :math:`t_1` *matches* another operand ty
\vdash \bot \leq t
}

.. math::
\frac{
(\vdash t \leq t')^\ast
}{
\vdash [t^\ast] \leq [{t'}^\ast]
}

.. note::
For example, the instruction :math:`\I32.\ADD` has type :math:`[\I32~\I32] \to [\I32]`,
consuming two |I32| values and producing one.
Expand Down Expand Up @@ -949,23 +957,28 @@ Control Instructions
:math:`\BRTABLE~l^\ast~l_N`
...........................


* The label :math:`C.\CLABELS[l_N]` must be defined in the context.

* Let :math:`[t^\ast]` be the :ref:`result type <syntax-resulttype>` :math:`C.\CLABELS[l_N]`.

* For all :math:`l_i` in :math:`l^\ast`,
the label :math:`C.\CLABELS[l_i]` must be defined in the context.

* For all :math:`l_i` in :math:`l^\ast`,
:math:`C.\CLABELS[l_i]` must be :math:`[t^\ast]`.
* There must be a :ref:`result type <syntax-resulttype>` :math:`[t^\ast]`, such that:

* For each :ref:`operand type <syntax-opdtype>` :math:`t_j` in :math:`t^\ast` and corresponding type :math:`t'_{Nj}` in :math:`C.\CLABELS[l_N]`, :math:`t_j` :ref:`matches <match-opdtype>` :math:`t'_{Nj}`.

* For all :math:`l_i` in :math:`l^\ast`,
and for each :ref:`operand type <syntax-opdtype>` :math:`t_j` in :math:`t^\ast` and corresponding type :math:`t'_{ij}` in :math:`C.\CLABELS[l_i]`, :math:`t_j` :ref:`matches <match-opdtype>` :math:`t'_{ij}`.

* Then the instruction is valid with type :math:`[t_1^\ast~t^\ast~\I32] \to [t_2^\ast]`, for any sequences of :ref:`value types <syntax-valtype>` :math:`t_1^\ast` and :math:`t_2^\ast`.

.. math::
\frac{
(C.\CLABELS[l] = [t^\ast])^\ast
(\vdash [t^\ast] \leq C.\CLABELS[l])^\ast
\qquad
C.\CLABELS[l_N] = [t^\ast]
\vdash [t^\ast] \leq C.\CLABELS[l_N]
}{
C \vdashinstr \BRTABLE~l^\ast~l_N : [t_1^\ast~t^\ast~\I32] \to [t_2^\ast]
}
Expand Down Expand Up @@ -1088,7 +1101,7 @@ Non-empty Instruction Sequence: :math:`\instr^\ast~\instr_N`
\frac{
C \vdashinstrseq \instr^\ast : [t_1^\ast] \to [t_0^\ast~{t'}^\ast]
\qquad
(\vdash t' \leq t)^\ast
\vdash [{t'}^\ast] \leq [t^\ast]
\qquad
C \vdashinstr \instr_N : [t^\ast] \to [t_3^\ast]
}{
Expand Down Expand Up @@ -1121,7 +1134,7 @@ Expressions :math:`\expr` are classified by :ref:`result types <syntax-resulttyp
\frac{
C \vdashinstrseq \instr^\ast : [] \to [{t'}^\ast]
\qquad
(\vdash t' \leq t)^\ast
\vdash [{t'}^\ast] \leq [t^\ast]
}{
C \vdashexpr \instr^\ast~\END : [t^\ast]
}
Expand Down