Tighten checks in JS.md for imported and table functions #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -160,11 +160,19 @@ function, global, memory and table imports): | |||
| * Let `v` be the value of performing [`Get`](http://tc39.github.io/ecma262/#sec-get-o-p)(`v`, `i.export_name`) | |||
| * If `i` is a function import: | |||
| * If `IsCallable(v)` is `false`, throw a [`TypeError`](https://tc39.github.io/ecma262/#sec-native-error-types-used-in-this-standard-typeerror). | |||
There was a problem hiding this comment.
Can you make IsCallable(v) a link to the JavaScript standard, i.e. IsCallable(v)
|
looks good to me with nits. |
|
Good points, updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fills in some missing checks in the JS API that we've discussed informally but never got recorded. It's possible we'll want to relax the restriction on not being able to assign non-exported-wasm functions to Tables post-MVP, but for now it reduces the MVP impl burden of Tables while still supporting the core use case of dynamic linking.