Fix Memory64 binary parsing after #4811 #4933
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kripken
commented
Aug 18, 2022
| } | ||
| throwError("Memory index out of range."); | ||
| } | ||
|
|
There was a problem hiding this comment.
This code is just moved.
ashleynh
approved these changes
Aug 18, 2022
|
(Landing to try to unbreak the roller, but we can continue discussion here and have followups if necessary.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to missing test coverage, we missed in #4811 that some memory operations
needed to get
make64()called on them.This should unbreak the Binaryen roller.