Skip to content

Temprorary disable Wasm2C and Wasm2C2Wasm in fuzz_opt #4724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

MaxGraey
Copy link
Contributor

Fix #4723

@kripken
Copy link
Member

kripken commented Jun 14, 2022

Reading wasm-binary.h, I think 0x4f (mentioned in #4723) means an isorecursive recursion group, which is a wasm GC type structure. I think we should just disable wasm2c on wasm GC. But looks like that's already the case,

return all_disallowed(['exception-handling', 'simd', 'threads', 'bulk-memory', 'nontrapping-float-to-int', 'tail-call', 'sign-ext', 'reference-types', 'multivalue', 'gc'])

So I'm not sure what's going wrong here. It would be good to investigate and see why we run with GC (why that code fails to stop us).

@MaxGraey
Copy link
Contributor Author

Could that change be a reason? #4633. I guess wabt/wasm2c doesn't have similar changes

@kripken
Copy link
Member

kripken commented Jun 14, 2022

That could be a separate reason. But like recursion groups, externref is only used in GC, and we should already be skipping wasm2c with GC, so that needs to be figured out.

@MaxGraey MaxGraey changed the title Temprorary disable Wasm2C and Wasm2C2Wasm in tuzz_opt Temprorary disable Wasm2C and Wasm2C2Wasm in fuzz_opt Jun 15, 2022
@MaxGraey
Copy link
Contributor Author

Closed in favour of #4738

@MaxGraey MaxGraey closed this Jun 17, 2022
@MaxGraey MaxGraey deleted the skip-wasm2c branch June 17, 2022 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fuzz_opt fail due to parsing / validating issue in wasm2c
2 participants