Skip to content

[EH] Allow catch/delegate-less trys #3924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/wasm/wasm-binary.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6069,10 +6069,12 @@ void WasmBinaryBuilder::visitTryOrTryInBlock(Expression*& out) {
// blocks instead.
curr->type = getType();
curr->body = getBlockOrSingleton(curr->type);
if (lastSeparator != BinaryConsts::Catch &&
lastSeparator != BinaryConsts::CatchAll &&
lastSeparator != BinaryConsts::Delegate) {
throwError("No catch instruction within a try scope");

// try without catch or delegate
if (lastSeparator == BinaryConsts::End) {
curr->finalize();
out = curr;
return;
}

Builder builder(wasm);
Expand Down Expand Up @@ -6189,7 +6191,7 @@ void WasmBinaryBuilder::visitTryOrTryInBlock(Expression*& out) {
// (catch $e
// (block ;; Now this can be deleted when writing binary
// ...
// (br $label0)
// (br $label)
// )
// )
// )
Expand Down
3 changes: 0 additions & 3 deletions src/wasm/wasm-s-parser.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2470,9 +2470,6 @@ Expression* SExpressionWasmBuilder::makeTry(Element& s) {
throw ParseException(
"there should be at most one catch_all block at the end", s.line, s.col);
}
if (ret->catchBodies.empty() && !ret->isDelegate()) {
throw ParseException("no catch bodies or delegate", s.line, s.col);
}

ret->finalize(type);

Expand Down
3 changes: 0 additions & 3 deletions src/wasm/wasm-validator.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2078,9 +2078,6 @@ void FunctionValidator::visitTry(Try* curr) {
shouldBeFalse(curr->isCatch() && curr->isDelegate(),
curr,
"try cannot have both catch and delegate at the same time");
shouldBeTrue(curr->isCatch() || curr->isDelegate(),
curr,
"try should have either catches or a delegate");

if (curr->isDelegate()) {
noteDelegate(curr->delegateTarget, curr);
Expand Down
7 changes: 7 additions & 0 deletions test/exception-handling.wast
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,13 @@
)
)
)

;; try without catch or delegate
(try
(do
(throw $e-i32 (i32.const 0))
)
)
)

(func $delegate-test
Expand Down
67 changes: 37 additions & 30 deletions test/exception-handling.wast.from-wast
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,13 @@
)
)
)
(try $try10
(do
(throw $e-i32
(i32.const 0)
)
)
)
)
(func $delegate-test
(try $l0
Expand All @@ -180,7 +187,7 @@
)
(delegate $l0)
)
(try $try10
(try $try11
(do
(call $foo)
)
Expand All @@ -191,43 +198,43 @@
(nop)
)
)
(block $l014
(try $l011
(block $l015
(try $l012
(do
(try $try12
(try $try13
(do
(br_if $l014
(br_if $l015
(i32.const 1)
)
)
(delegate $l011)
(delegate $l012)
)
(try $try13
(try $try14
(do
(br_if $l014
(br_if $l015
(i32.const 1)
)
)
(delegate $l011)
(delegate $l012)
)
)
(catch_all
(nop)
)
)
)
(try $l015
(try $l016
(do
(try $try16
(try $try17
(do
(call $foo)
)
(delegate $l015)
(delegate $l016)
)
)
(delegate 0)
)
(try $try17
(try $try18
(do
(nop)
)
Expand All @@ -251,23 +258,23 @@
(rethrow $l0)
)
)
(block $l019
(try $l018
(block $l020
(try $l019
(do
(call $foo)
)
(catch $e-i32
(drop
(pop i32)
)
(rethrow $l018)
(rethrow $l019)
)
(catch_all
(br $l019)
(br $l020)
)
)
)
(try $l020
(try $l021
(do
(call $foo)
)
Expand All @@ -280,20 +287,20 @@
(drop
(pop i32)
)
(rethrow $l020)
(rethrow $l021)
)
(catch_all
(rethrow $l020)
(rethrow $l021)
)
)
)
)
(try $l021
(try $l022
(do
(call $foo)
)
(catch_all
(try $try22
(try $try23
(do
(call $foo)
)
Expand All @@ -302,40 +309,40 @@
(pop i32)
)
(block $b0
(rethrow $l021)
(rethrow $l022)
)
)
(catch_all
(block $b1
(rethrow $l021)
(rethrow $l022)
)
)
)
)
)
(try $l023
(try $l024
(do
(call $foo)
)
(catch_all
(try $try24
(try $try25
(do
(rethrow $l023)
(rethrow $l024)
)
(catch_all
(nop)
)
)
)
)
(try $l025
(try $l026
(do
(call $foo)
)
(catch_all
(try $try26
(try $try27
(do
(rethrow $l025)
(rethrow $l026)
)
(catch_all
(nop)
Expand Down
7 changes: 7 additions & 0 deletions test/exception-handling.wast.fromBinary
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,13 @@
)
)
)
(try
(do
(throw $event$0
(i32.const 0)
)
)
)
)
(func $delegate-test
(try $label$9
Expand Down
7 changes: 7 additions & 0 deletions test/exception-handling.wast.fromBinary.noDebugInfo
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,13 @@
)
)
)
(try
(do
(throw $event$0
(i32.const 0)
)
)
)
)
(func $3
(try $label$9
Expand Down