-
Notifications
You must be signed in to change notification settings - Fork 5
refactor(Application): Remove remaining FlexLayout #2215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+1,521
−2,303
Merged
Changes from all commits
Commits
Show all changes
147 commits
Select commit
Hold shift + click to select a range
98bb506
Remove FlexLayout from PeerReviewAndRevisionComponent
hirokiterashima 26332ef
Remove FlexLayout from AddProjectComponent
hirokiterashima e3dccf8
Remove FlexLayout from NodeNavigationComponent
hirokiterashima 3676285
Remove FlexLayout from NotebookItemComponent
hirokiterashima 0fd4e56
Remove FlexLayout from MoveUserConfirmDialogComponent and clean up code
hirokiterashima 52c0f64
Remove FlexLayout from ComponentAnnotationsComponent
hirokiterashima 794e6ad
Remove FlexLayout from ManageTagsDialogComponent
hirokiterashima cb0597b
Remove FlexLayout from ManageUserComponent
hirokiterashima f924650
Remove FlexLayout from ManagePeriodComponent
hirokiterashima 8d03c6b
Remove FlexLayout from NotebookReportComponent
hirokiterashima a4e166c
Remove FlexLayout from ClassroomMonitorComponent
hirokiterashima 970f45c
Remove FlexLayout from ToolBarComponent
hirokiterashima dfa86ea
Remove FlexLayout from DialogWithSpinnerComponent
hirokiterashima f4207a9
Remove FlexLayout from NewsComponent
hirokiterashima 580568b
Remove FlexLayout from GenerateImageDialogComponent
hirokiterashima 67843ab
Remove FlexLayout from MainMenuComponent
hirokiterashima 58951f2
Remove FlexLayout from ExportStepVisitsComponent
hirokiterashima 2ae53cb
Remove FlexLayout from ExportEventsComponent
hirokiterashima 10ef21d
Remove FlexLayout from ExportItemComponent
hirokiterashima 13bbe03
Remove FlexLayout from ExportRawDataComponent
hirokiterashima 96b47d8
Remove FlexLayout from DataExportComponent
hirokiterashima b9f366c
Remove FlexLayout from SelectStepAndComponentCheckboxesComponent
hirokiterashima fe78449
Upgrade to Angular 20
hirokiterashima c554166
Upgrade buildspec nodejs version to work with Angular 20
hirokiterashima 85e069f
Merge branch 'remove-flex-layout-aug-2025' into remove-remaining-flex…
hirokiterashima 04a0fa5
Merge branch 'develop' into remove-remaining-flex-layout
hirokiterashima 6ca4e26
Merge branch 'develop' into remove-remaining-flex-layout
hirokiterashima e5b548b
Remove FlexLayout from WorkgroupInfoComponent
hirokiterashima 5221853
Remove FlexLayout from PauseScreensMenuComponent
hirokiterashima d12cf77
Remove FlexLayout from WorkgroupNodeScoreComponent
hirokiterashima 1754066
Remove FlexLayout from SelectStepAndComponentCheckboxesComponent
hirokiterashima b26eede
Remove FlexLayout from NotificationsMenuComponent
hirokiterashima fe61e4f
Remove FlexLayout from StepToolsComponent
hirokiterashima db06563
Remove FlexLayout from ChangeStudentPasswordDialogComponent
hirokiterashima bd0c8a6
Remove FlexLayout from EditComponentScoreComponent
hirokiterashima c1954f9
Remove FlexLayout from EditComponentAnnotationsComponent
hirokiterashima ea2d964
Remove FlexLayout from NavItemProgressComponent
hirokiterashima a0da946
Remove FlexLayout from StepInfoComponent
hirokiterashima 3e96212
Remove FlexLayout from NavItemScoreComponent
hirokiterashima b62ccda
Remove FlexLayout from NodeInfoComponent
hirokiterashima 0a87d4b
Remove FlexLayout from NavItemComponent
hirokiterashima f3a5a0e
Remove FlexLayout from ProjectProgressComponent
hirokiterashima 1d5dd17
Remove FlexLayout from MilestoneDetailsComponent
hirokiterashima 299ce61
Remove FlexLayout from PeerGroupDialogComponent
hirokiterashima be55b27
Remove FlexLayout from PeerGroupWorkgroupComponent
hirokiterashima a1078b2
Remove FlexLayout from PeerGroupGroupingComponent
hirokiterashima b4ef291
Remove FlexLayout from PeerGroupPeriodComponent
hirokiterashima 8043994
Remove FlexLayout from PeerGroupMoveWorkgroupConfirmDialogComponent
hirokiterashima 289bae8
Remove FlexLayout from StudentGradingToolsComponent
hirokiterashima 900a2ce
Remove FlexLayout from PeerGroupAssignedWorkgroupsComponent (partial)
hirokiterashima f65f4f2
Fix unit test
hirokiterashima a5ac598
Merge branch 'develop' into remove-remaining-flex-layout
hirokiterashima b25a43a
Remove FlexLayout from ComputerAvatarSelectorComponent
hirokiterashima 046965b
Remove FlexLayout from EditTagComponent
hirokiterashima b9bf812
Remove FlexLayoutModule dep from HeaderLinksComponent, FooterComponen…
hirokiterashima 70dcb7a
Remove FlexLayout from LoginModule and clean up related files
hirokiterashima 1de8e4a
Remove FlexLayout from ContactModule and clean up related files
hirokiterashima f70dacb
Remove FlexLayout from LibraryProjectDetailsComponent
hirokiterashima 2d16a56
Merge branch 'develop' into remove-remaining-flex-layout
hirokiterashima c9ad464
Remove FlexLayout from AiChatModule and clean up related files
hirokiterashima 58ebd25
Remove FlexLayout from PasswordModule and clean up related files
hirokiterashima fba9244
Remove FlexLayout from DiscussionCommonModule and clean up related files
hirokiterashima ebd342a
Remove FlexLayout from MilestonesComponent
breity a1d2d68
Clean up ContactFormComponent
breity 34438c1
Updated messages
github-actions[bot] ca6316e
Remove FlexLayout from spec files
hirokiterashima 5563d20
Remove FlexLayout from StudentAssetsDialogModule and clean up related…
hirokiterashima 03befef
Remove FlexLayout from AppComponent template and clean up related files
hirokiterashima e2a0530
Remove FlexLayout from PeerChatGradingModule and clean up related fil…
hirokiterashima f2c1256
Remove FlexLayout from PeerChatShowWorkModule and clean up related files
hirokiterashima 1fbf8e7
Clean up and remove FlexLayout from DiscourseLatestNewsComponent
breity 9afc105
Remove FlexLayout from NodeWorkgroupItem
breity 7b9ea83
Merge remote-tracking branch 'origin/remove-remaining-flex-layout' in…
hirokiterashima 5cff31f
Remove FlexLayout from NotebookNotesComponent
breity 7acd0f2
Remove FlexLayout from ShowGroupWorkDisplayComponent and clean up rel…
hirokiterashima e810eb9
Merge remote-tracking branch 'origin/remove-remaining-flex-layout' in…
hirokiterashima 824c8e0
Fix app layout (AT was not showing up)
hirokiterashima 644a19a
Remove FlexLayout from StudentAccountMenuComponent and clean up relat…
hirokiterashima 337ee16
Remove FlexLayout from MobileMenuComponent and clean up related files
hirokiterashima d74bac7
Remove FlexLayout from CallToActionComponent and clean up related files
hirokiterashima 36872b0
Remove FlexLayout from EditComponentCommentComponent and clean up rel…
hirokiterashima 4322d34
Remove FlexLayout from EditNotebookItemDialogModule and clean up rela…
hirokiterashima a169613
Remove FlexLayout from DismissAmbientNotificationDialogModule and cle…
hirokiterashima d3b9503
Remove FlexLayout from PeerChatStudentModule and clean up related files
hirokiterashima c8653a4
Remove FlexLayout from PeerChatModule and clean up related files
hirokiterashima 8dd68a5
Remove FlexLayout from MatchCommonModule and clean up related files
hirokiterashima d08a80c
Remove FlexLayout from LibraryModule and clean up related files
hirokiterashima 96c2b62
Merge branch 'develop' into remove-remaining-flex-layout
hirokiterashima d2c540c
Remove FlexLayout from TeacherModule and clean up related files
hirokiterashima 42a9493
Remove FlexLayout from StudentModule and clean up related files
hirokiterashima 3e8d170
Remove FlexLayout from NotebookModule and clean up related files. Con…
hirokiterashima fc6c78a
Remove FlexLayout from DiscourseCategoryActivityComponent
hirokiterashima d2dea31
Remove FlexLayout from GradingStepToolsComponent and clean up related…
hirokiterashima e4b8c5a
Remove FlexLayout from EditComponentCommentComponent
hirokiterashima c9c6462
Update DiscoursLatestNewsComponent to match Tailwind breakpoints
breity f5eaaa7
Remove FlexLayout from HeroSectionComponent
breity 0bcc72c
Removed WorkgroupItemComponent. No longer used.
hirokiterashima eaeb6de
Remove FlexLayout from ManageTeamComponent
breity 1f05c31
Remove FlexLayout from ManageTeamComponents
breity a04632e
Updated messages
github-actions[bot] f7d7057
Remove FlexLayout from AddTeamDialogComponent
breity 34a1bcf
Updated messages
github-actions[bot] e826f39
Remove FlexLayout from TopBarComponent
breity f3f4b28
Updated messages
github-actions[bot] ecee7c5
Remove FlexLayout from StepItemComponent
breity 21bac48
Updated messages
github-actions[bot] f9635f9
Remove FlexLayout from StudentProgressComponent
breity 9e26657
Updated messages
github-actions[bot] 9a0c830
Remove FlexLayout from NodeIconChooserComponent
breity d8a01bb
Updated messages
github-actions[bot] fc45b07
Remove FlexLayout from ViewComponentRevisionsComponent
breity aab0802
Updated messages
github-actions[bot] f52fd31
Remove FlexLayout from PeerGroupAssignedWorkgroupsComponent
breity 8654509
Remove FlexLayout from PeerGroupUnssignedWorkgroupsComponent
breity c374a8f
Fix layout for PeerGroupDialogComponent
breity ce92387
Fix layout for PeerGroupMoveWorkgroupsComponent
breity 76fc9ad
Fix StepItemComponent and StudentGradingComponent layout
breity 9f9c6d4
Updated messages
github-actions[bot] a0fc10a
Remove FlexLayout from WorkgroupComponentGradingsComponent
breity c32ac10
Remove FlexLayout from and restore MilestoneClassResponsesComponent
breity cdd58ea
Remove FlexLayout from MilestoneWorkgroupItemComponent
breity 955f0b3
Updated messages
github-actions[bot] a1889b5
Remove FlexLayout from and clean up DiscussionStudentComponent
breity 3f26e39
Updated messages
github-actions[bot] 5b17736
Remove FlexLayout from HomeComponent
breity b9451ae
Updated messages
github-actions[bot] ad7718b
Remove FlexLayout from PeerGroupUnassignedWorkgroupsComponent spec an…
hirokiterashima 990ef59
Remove FlexLayout from NodeProgressViewComponent
breity e51731e
Remove FlexLayout from NotebookWorkgroupGradingComponent
breity b2a5bca
Remove FlexLayout from NotebookGradingCompnent
breity 1742d92
Updated messages
github-actions[bot] 0c4d02d
Remove FlexLayout from StudentTeacherCommonModule and SharedModule
breity 4b92bb7
Remove FlexLayout from forgot component
breity 7072b36
Remove FlexLayout from OutsideUrlAuthoringComponent
breity 603588d
Updated messages
github-actions[bot] cf42a03
Remove FlexLayout from NotebookReportComponent
breity 49840b5
Remove FlexLayout from AppComponent
breity df0e7cc
Remove FlexLayout from AppComponent tests
breity c6c7a2a
Updated messages
github-actions[bot] d580eb3
Remove flex-layout dependency
breity 26a12df
Merge branch 'develop' into remove-remaining-flex-layout
breity 9a86cbf
Fix teacher home and class schedule header layout
breity f045afb
Updated messages
github-actions[bot] e09910e
Fix alignment of Team column header in MilestoneClassResponsesComponent
breity 0fa16cc
Fix node NodeIconComponent button background size
breity aac5e17
Fix MilestonesComponent layout alignment
breity e501fff
Center align milestone completion text
breity File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,11 +4,11 @@ import { Router, NavigationEnd, NavigationStart } from '@angular/router'; | |
import { DomSanitizer } from '@angular/platform-browser'; | ||
import { MatIconRegistry } from '@angular/material/icon'; | ||
import { Subscription } from 'rxjs'; | ||
import { MediaChange, MediaObserver } from '@angular/flex-layout'; | ||
import { UtilService } from './services/util.service'; | ||
import { ConfigService } from './services/config.service'; | ||
import { Announcement } from './domain/announcement'; | ||
import { environment } from '../environments/environment'; | ||
import { BreakpointObserver } from '@angular/cdk/layout'; | ||
declare let gtag: Function; | ||
|
||
@Component({ | ||
|
@@ -21,7 +21,6 @@ export class AppComponent { | |
title = 'app'; | ||
showMobileMenu: boolean = false; | ||
theme: string = ''; | ||
mediaWatcher: Subscription; | ||
googleAnalyticsId: string = null; | ||
hasAnnouncement: boolean = false; | ||
showDefaultMode: boolean = true; | ||
|
@@ -37,13 +36,13 @@ export class AppComponent { | |
}; | ||
|
||
constructor( | ||
private router: Router, | ||
private breakpointObserver: BreakpointObserver, | ||
private configService: ConfigService, | ||
@Inject(DOCUMENT) private document: Document, | ||
iconRegistry: MatIconRegistry, | ||
private router: Router, | ||
sanitizer: DomSanitizer, | ||
utilService: UtilService, | ||
media: MediaObserver, | ||
private configService: ConfigService, | ||
@Inject(DOCUMENT) private document: Document | ||
utilService: UtilService | ||
qltysh[bot] marked this conversation as resolved.
Show resolved
Hide resolved
qltysh[bot] marked this conversation as resolved.
Show resolved
Hide resolved
qltysh[bot] marked this conversation as resolved.
Show resolved
Hide resolved
qltysh[bot] marked this conversation as resolved.
Show resolved
Hide resolved
qltysh[bot] marked this conversation as resolved.
Show resolved
Hide resolved
qltysh[bot] marked this conversation as resolved.
Show resolved
Hide resolved
qltysh[bot] marked this conversation as resolved.
Show resolved
Hide resolved
qltysh[bot] marked this conversation as resolved.
Show resolved
Hide resolved
qltysh[bot] marked this conversation as resolved.
Show resolved
Hide resolved
Comment on lines
38
to
+45
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
) { | ||
iconRegistry.addSvgIcon( | ||
'ki-elicit', | ||
|
@@ -96,10 +95,8 @@ export class AppComponent { | |
utilService.getMobileMenuState().subscribe((state) => { | ||
this.showMobileMenu = state; | ||
}); | ||
this.mediaWatcher = media.asObservable().subscribe((change: MediaChange[]) => { | ||
if (media.isActive('gt-sm')) { | ||
utilService.showMobileMenu(false); | ||
} | ||
this.breakpointObserver.observe(['(max-width: 40rem)']).subscribe((result) => { | ||
utilService.showMobileMenu(false); | ||
}); | ||
router.events.subscribe((event) => { | ||
utilService.showMobileMenu(false); | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
4 changes: 1 addition & 3 deletions
4
src/app/classroom-monitor/nav-item-progress/nav-item-progress.component.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 5 additions & 13 deletions
18
src/app/classroom-monitor/step-info/step-info.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.