Skip to content

fix(Session): Remove stale sessions #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2022
Merged

fix(Session): Remove stale sessions #148

merged 1 commit into from
Jul 7, 2022

Conversation

hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Jul 6, 2022 •
edited
Loading

Changes

Test Prep

  • Flush session in Redis to avoid version conflict via flushall
  • Set server.servlet.session.timeout=1m in application-dockerdev.properties. This will logout the session after 1 minute of inactivity.
  • Run mvn clean compile to get new Maven dependencies, then restart the API server. This will start WISE-API using SpringBoot 2.5.10

Test

  • Log in as admin user in one browser and log in and out as a teacher or student in others.
  • In the admin view, verify that the "List All Users Who Logged In Now (X)" has the right number as other users log in and out.
  • Clicking on the "Now" link should take you to /admin/account/show-online-users which is now backed by the new ShowOnlineUsersController, and show the users who are currently logged in.

Closes #3

@hirokiterashima
fix(Session): Remove stale sessions
63aab13 
- Upgrade to SpringBoot 2.5.10 to get fix spring-projects/spring-session#1791
- Go through current users and remove any stale sessions when admin
  accesses index page
- Refactor page to show current users to new ShowOnlineUsersController
@hirokiterashima hirokiterashima marked this pull request as ready for review July 7, 2022 03:32
geoffreykwan
geoffreykwan approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit b9fe46c into develop Jul 7, 2022
@hirokiterashima hirokiterashima deleted the issue-3-remove-stale-user-sessions branch July 7, 2022 23:25
@geoffreykwan
Copy link
Member

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreykwan geoffreykwan geoffreykwan approved these changes

Assignees

@geoffreykwan geoffreykwan

Labels
released
Projects
WISE Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove stale user session entry from Redis Session IDs are not cleaned up in principal index after Session ID changed when using Redis
2 participants
@hirokiterashima @geoffreykwan