Skip to content

Conversation

suratdas
Copy link
Collaborator

Fixes #48

@suratdas
Copy link
Collaborator Author

Tested locally and works fine with the java-examples I pushed earlier. Also, all unit tests are passing. The check complains because it set up java 8 to run but it will run with java 11. Also, my IntelliJ auto formatted some imports and indentations.
BTW, are we mandating our consumers to use Java 11 to be able to use this repo ?

@pashidlos
Copy link
Member

pashidlos commented Dec 30, 2020

@suratdas thanks for contribution!

only now I realised it's not gonna be compatible with java 8 :)
you could change .github/workflows/gradle.yml with Java version 11 and it should work

are we mandating our consumers to use Java 11 to be able to use this repo ?

yeah, let's make 11 as minimum required

np, I'll make it major version 5.0.0

@codecov-io
Copy link

codecov-io commented Dec 30, 2020

Codecov Report

Merging #54 (59afd3e) into master (6f3b630) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master       #54   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity        27        31    +4     
===========================================
  Files              5         5           
  Lines            110       108    -2     
  Branches           4         4           
===========================================
- Hits             110       108    -2     
Impacted Files Coverage Δ Complexity Δ
...sion_tracker/sdk_java/VisualRegressionTracker.java 100.00% <100.00%> (ø) 22.00 <6.00> (+4.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f3b630...59afd3e. Read the comment docs.

@suratdas suratdas force-pushed the java-11-migration branch 2 times, most recently from 5376592 to f12c1c1 Compare December 30, 2020 20:16
@pashidlos
Copy link
Member

pashidlos commented Dec 30, 2020

not sure why but jitpack is not building new version 5.0.0-SNAPSHOT
seems somewhere we need to setup java 11 for it
https://jitpack.io/com/github/Visual-Regression-Tracker/sdk-java/5.0.0-SNAPSHOT/build.log

@suratdas
Copy link
Collaborator Author

not sure why but jitpack is not building new version 5.0.0-SNAPSHOT
seems somewhere we need to setup java 11 for it
https://jitpack.io/com/github/Visual-Regression-Tracker/sdk-java/5.0.0-SNAPSHOT/build.log

Looks like we need jitpack.yml file per the comment at jitpack/jitpack.io#2567 (comment)

@suratdas
Copy link
Collaborator Author

@pashidlos Did you figure out the jitpack build issue for Java 11 ? Sorry, I never worked with jitpack. So, cannot help immediately.

@pashidlos
Copy link
Member

@suratdas me neither )
I guess you could create this file and let's check if it works

@pashidlos
Copy link
Member

LGTM!
@suratdas thanks for contribution!

@pashidlos pashidlos merged commit f67f11e into master Jan 21, 2021
@pashidlos pashidlos deleted the java-11-migration branch January 21, 2021 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to java 11
3 participants