Fix --watch failing on invalid PathWatchers.Event & skip wonky tests on Mac CI
#2515
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
swoval'sPathWatchers.Eventsometimes returned a path, for which theRelPathwe checked in the event filter didn't have an availablelastsegment (as it was probably empty) and reacted with aPathError. 🤡Which was then hard to see, as it was hidden behind a timeout in
BloopTests.Restart Bloop server while watching.I can't replicate this locally.
Example failure: https://github.com/VirtusLab/scala-cli/actions/runs/6683093329/job/18159052355#step:5:503
This should hopefully address this (or at the very least give us a meaningful exception if it still fails).
Beyond that,
RunTestsDefault.watch artifacts&BloopTests.Restart Bloop server while watchingwill temporarily be skipped for Mac OS only (until we find a way to make those pass reliably on Mac CI, as they've been making intermittent errors a headache)