Skip to content

Conversation

mateusz-kleszcz
Copy link
Contributor

Ticket

#316

Summary

This PR introduced pagination to the GET with children endpoint. It is based on another PR, but resolves some of its issues (lack of children nested more than one level, removes children when using /flat endpoint)

Test Plan

  • create comments with nested children (threadOf property)
  • try to fetch them with findAllInHierarchy endpoint, check if structure is unchanged
  • add a pagination[pageSize] and pagination[page] query params, check if only paginated comments are returned

@mateusz-kleszcz mateusz-kleszcz self-assigned this Aug 28, 2025
@mateusz-kleszcz mateusz-kleszcz added bug Something isn't working documentation Improvements or additions to documentation rest REST API issue v5 labels Aug 28, 2025
@cyp3rius cyp3rius merged commit ad9e1b9 into master Aug 28, 2025
3 checks passed
@cyp3rius cyp3rius deleted the fix-316/paginated-get-children branch August 28, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation rest REST API issue v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants