-
Notifications
You must be signed in to change notification settings - Fork 3
Added : Notifications #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… in chat application
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anshu370,
The updates look good to me! I have a few follow-up points to ensure everything is in line:
-
Could you please provide a quick demo video showing the updated application in action? It would help us validate the recent changes visually.
-
Regarding
requirements.txt
, could you confirm if it was generated specifically for this application? Were you working within a virtual environment before runningpip freeze
, or does it include other dependencies outside of this project? -
Also, I noticed the port was changed from
12345
to1234
. Was there a specific reason for this adjustment?
Thanks for your work on this!
Hey @Vikranth3140 ,
2024-11-05.09-23-08.mp4
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have change it to 1234 for testing in multiple computers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, lgtm, i have some changes which i'll do.
A few more points:
- What timestamp is the notification coming.
- Update the README and add notifications.
- Add a new issue explaining the problem you are trying to solve.
- Add the
tkinter
inrequirements.txt
okay in will do the changes. |
Notifications for user join/leave and Message Received events in chat application