Skip to content
This repository was archived by the owner on Aug 23, 2025. It is now read-only.

Refactor ImgGen core component #1

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Refactor ImgGen core component #1

wants to merge 1 commit into from

Conversation

jchris
Copy link
Contributor

@jchris jchris commented May 27, 2025

Summary

  • split the big ImgGen file
  • move core logic to ImgGenCore
  • extract ImgGenProps type

Testing

  • npm test

@netlify Netlify
Copy link

netlify bot commented May 27, 2025 •
edited
Loading

❌ Deploy Preview for use-vibes failed. Why did it fail? →

Name Link
🔨 Latest commit f7ee025
🔍 Latest deploy log https://app.netlify.com/projects/use-vibes/deploys/683605f9820ae20008cbfe2c

mabels
mabels reviewed Jul 19, 2025
View reviewed changes
Copy link
Contributor

@mabels mabels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like it ---

  • use readonly where you can.
  • and don't mix undefined and null --- null is common but a ugly beast typeof null === 'object'

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@mabels mabels mabels left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
codex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jchris @mabels