Skip to content

Conversation

@fmauch
Copy link
Contributor

@fmauch fmauch commented Jun 26, 2020

This PR adds automated integration tests to the CI pipeline

As the integration tests require a running robot where the driver connects to, we launch a ursim inside a docker container during the github actions run. To run the tests locally, users would have to make sure to provide a running instance reachable at the used IP address.

-p 30001-30004:30001-30004 \
-v "${DIR}/.vol":/ursim/programs \
-v dockursim:/ursim \
--privileged \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit unfortunate, but apparently URControl cannot be started without it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with both points.

maxMomentum = 25.0
maxJointSpeed = [3.3415926, 3.3415926, 3.3415926, 3.3415926, 3.3415926, 3.3415926]
minJointPosition = [6.2308254, 6.2308254, 6.2308254, 6.2308254, 6.2308254, 6.2308254]
maxJointPosition = [0.05235988, 0.05235988, 0.05235988, 0.05235988, 0.05235988, 0.05235988]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No! Thanks for spotting that! I've been playing around with the safety settings before exporting this file. That should be changed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps import a vanilla (ie: just extracted from the ursim archive) version of the file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: Yes, it is correct. I just downloaded it from a robot with default safety configuration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps import a vanilla (ie: just extracted from the ursim archive) version of the file?

In fact in the archive this file is empty so that the user has to confirm it first. This is why we actually do that step.

super(TrajectoryTest, self).__init__(*args)
rospy.init_node('trajectory_testing_client')
self.client = actionlib.SimpleActionClient(
'/scaled_pos_traj_controller/follow_joint_trajectory', FollowJointTrajectoryAction)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of hard-coding the topic name, it might be nicer to only spec follow_joint_trajectory here and then remap in the .test file.

@fmauch fmauch force-pushed the testing_scripts branch from 3027589 to 2380c4b Compare June 26, 2020 08:36
@fmauch fmauch force-pushed the testing_scripts branch 3 times, most recently from 3ab5899 to 88c539e Compare July 10, 2020 11:13
@fmauch fmauch force-pushed the testing_scripts branch from 4efc853 to 9207ca3 Compare July 10, 2020 12:03
@fmauch fmauch force-pushed the testing_scripts branch from 9207ca3 to f6196af Compare July 10, 2020 12:17
@fmauch fmauch merged commit 83c5e8c into UniversalRobots:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants