Succeed power on command on PolyScope 5 when robot is running #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We check for the robot state being IDLE and retry that with a very high timeout by default. This commit also accepts the robot to be in RUNNING in order to succeed.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #397 +/- ##
==========================================
- Coverage 42.86% 42.69% -0.17%
==========================================
Files 99 99
Lines 8623 8624 +1
Branches 1170 1170
==========================================
- Hits 3696 3682 -14
- Misses 4647 4662 +15
Partials 280 280
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We check for the robot state being IDLE and retry that with a very high timeout by default. This commit also accepts the robot to be in RUNNING in order to succeed.
Otherwise the robot will reply "Powering on" through the dashboard interface, but the state will stay unchanged because it is already idling. Thus, the call will fail (and block very long) while the pure dashboard call would be succeeding.