Skip to content

Conversation

@Elfi0Kuhndorf
Copy link
Contributor

@Elfi0Kuhndorf Elfi0Kuhndorf commented Jul 30, 2025

Description

Removing redundant packages from the Boss Room sample. Should I mention this in the changelog?

Issue Number(s)

https://jira.unity3d.com/browse/MTT-12851

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@Elfi0Kuhndorf Elfi0Kuhndorf requested a review from a team as a code owner July 30, 2025 11:34
Copy link
Contributor

@RikuTheFuffs RikuTheFuffs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we actually need:

"jp.hadashikick.vcontainer": "1.16.8",
"com.unity.modules.cloth": "1.0.0",
"com.unity.modules.terrain": "1.0.0",
"com.unity.modules.terrainphysics": "1.0.0",
"com.unity.modules.assetbundle": "1.0.0",

?

@RikuTheFuffs
Copy link
Contributor

Should I mention this in the changelog?

if they were unused, I don't see the point.

@Elfi0Kuhndorf
Copy link
Contributor Author

Do we actually need:

"jp.hadashikick.vcontainer": "1.16.8", "com.unity.modules.cloth": "1.0.0", "com.unity.modules.terrain": "1.0.0", "com.unity.modules.terrainphysics": "1.0.0", "com.unity.modules.assetbundle": "1.0.0",

?

Yeah those ones I were not able to see in the package manager, but I can try to remove them directly from the manifest and see if it breaks anything

RikuTheFuffs
RikuTheFuffs previously approved these changes Jul 30, 2025
Copy link
Contributor

@RikuTheFuffs RikuTheFuffs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that we're able to remove "com.unity.2d.sprite": "1.0.0", i thought it was necessary for sprites to work.

@Elfi0Kuhndorf
Copy link
Contributor Author

Weird that we're able to remove "com.unity.2d.sprite": "1.0.0", i thought it was necessary for sprites to work.

Nope apparently it is not necessary. Maybe it is more intended for if using sprites in a tilemap?

@Elfi0Kuhndorf Elfi0Kuhndorf merged commit 96b18b2 into develop Aug 4, 2025
16 checks passed
@Elfi0Kuhndorf Elfi0Kuhndorf deleted the fix/remove-redundant-dependencies branch August 4, 2025 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants