-
Couldn't load subscription status.
- Fork 575
[MTT-12851] Fix/remove redundant dependencies #923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we actually need:
"jp.hadashikick.vcontainer": "1.16.8",
"com.unity.modules.cloth": "1.0.0",
"com.unity.modules.terrain": "1.0.0",
"com.unity.modules.terrainphysics": "1.0.0",
"com.unity.modules.assetbundle": "1.0.0",
?
if they were unused, I don't see the point. |
Yeah those ones I were not able to see in the package manager, but I can try to remove them directly from the manifest and see if it breaks anything |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird that we're able to remove "com.unity.2d.sprite": "1.0.0", i thought it was necessary for sprites to work.
Nope apparently it is not necessary. Maybe it is more intended for if using sprites in a tilemap? |
Description
Removing redundant packages from the Boss Room sample. Should I mention this in the changelog?
Issue Number(s)
https://jira.unity3d.com/browse/MTT-12851
Contribution checklist