Skip to content

fix: name generation bounds fixed to include last item #922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: v2.3.0 release
merged 3 commits into from
Jul 28, 2025
Merged

fix: name generation bounds fixed to include last item #922

merged 3 commits into from
Jul 28, 2025

Conversation

@fernando-cortez
Copy link
Collaborator

Description

Small PR to fix the bounds issue inside of the player name generation, where the last item in the arrays for first and last nam weren't being used.

Issue Number(s)

Issue 912

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@fernando-cortez fernando-cortez marked this pull request as ready for review July 24, 2025 19:25
@fernando-cortez fernando-cortez requested a review from a team as a code owner July 24, 2025 19:25
kalmanbalint
kalmanbalint approved these changes Jul 24, 2025
View reviewed changes
Copy link

@kalmanbalint kalmanbalint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@fernando-cortez fernando-cortez merged commit 7336b3e into develop Jul 28, 2025
16 checks passed
@fernando-cortez fernando-cortez deleted the fix/name-generation branch July 28, 2025 21:30
@fernando-cortez fernando-cortez mentioned this pull request Aug 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RikuTheFuffs RikuTheFuffs RikuTheFuffs approved these changes

@kalmanbalint kalmanbalint kalmanbalint approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fernando-cortez @RikuTheFuffs @kalmanbalint