Skip to content

fix: v2.4.1 NGO TestHelpers update #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 7, 2025
Merged

fix: v2.4.1 NGO TestHelpers update #914

merged 4 commits into from
Jul 7, 2025

Conversation

@NoelStephensUnity
Copy link
Contributor

Description

Since NGO v2.4.1 and above will now house testhelpers within the runtime tests assembly, we need to add the Unity.Netcode.Runtime.Tests to the BossRoom's tests asmdef.

Issue Number(s)

NA

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@NoelStephensUnity
fix
4fa8cb6 
Since NGO v2.4.1 and above will now house testhelpers within the runtime tests assembly, we need to add the Unity.Netcode.Runtime.Tests to the BossRoom's tests asmdef.
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner June 17, 2025 19:55
@unity-cla-assistant
Copy link

unity-cla-assistant commented Jun 17, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@sentinel-u3d sentinel-u3d bot requested a review from fernando-cortez June 18, 2025 13:28
fernando-cortez
fernando-cortez previously approved these changes Jun 18, 2025
View reviewed changes
Copy link
Contributor

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just need to add a line to our changelog.
Thanks Noel, this looks great.

@fernando-cortez fernando-cortez requested a review from fluong6 July 3, 2025 16:45
@fernando-cortez fernando-cortez merged commit b4afa28 into develop Jul 7, 2025
15 of 16 checks passed
@fernando-cortez fernando-cortez deleted the fix/update-testhelpers-ngo-2-4-1 branch July 7, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fluong6 fluong6 fluong6 approved these changes

+1 more reviewer

@fernando-cortez fernando-cortez fernando-cortez left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@NoelStephensUnity @unity-cla-assistant @fernando-cortez @fluong6