Skip to content

fix: in scene NetworkObject null reference exception when hit/destroyed [MTT-11939] #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: v2.3.0 release
merged 3 commits into from
Apr 28, 2025
Merged

fix: in scene NetworkObject null reference exception when hit/destroyed [MTT-11939] #908

merged 3 commits into from
Apr 28, 2025

Conversation

@fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Apr 28, 2025 •
edited
Loading

Description

This PR fixes a NullReference exception logged when striking a Breakable object with a Melee action. Health NetworkVariables and max hp values have been generated for prefabs generating exceptions.

Issue Number(s)

MTT-11939

Contribution checklist

  • [ N/A ] Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • [ N/A ] An Index entry has been added in readme.md if applicable

@fernando-cortez fernando-cortez marked this pull request as ready for review April 28, 2025 16:43
@fernando-cortez fernando-cortez requested a review from a team as a code owner April 28, 2025 16:43
@sentinel-u3d sentinel-u3d bot requested a review from kalmanbalint April 28, 2025 16:53
kalmanbalint
kalmanbalint previously approved these changes Apr 28, 2025
View reviewed changes
Copy link

@kalmanbalint kalmanbalint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few questions and nit picks but overall looks good :)

feel free to ignore the nit picks if it's too much hassle to handle them

@kalmanbalint
Copy link

seems like you have a few lingering whitespaces that Yamato complains about:
https://unity-ci.cds.internal.unity3d.com/job/49922432/logs

kalmanbalint
kalmanbalint approved these changes Apr 28, 2025
View reviewed changes
Copy link

@kalmanbalint kalmanbalint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@fernando-cortez fernando-cortez merged commit 2fc8c1f into develop Apr 28, 2025
13 checks passed
@fernando-cortez fernando-cortez deleted the fix/in-scene-networkobject-null-reference-exception branch April 28, 2025 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kalmanbalint kalmanbalint kalmanbalint approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fernando-cortez @kalmanbalint