Skip to content

feat: upgrade to 6000.0.32f1 & multiplayer services v1.1.0 bump #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 14, 2025
Merged

feat: upgrade to 6000.0.32f1 & multiplayer services v1.1.0 bump #894

merged 4 commits into from
Jan 14, 2025

Conversation

@fernando-cortez
Copy link
Contributor

@fernando-cortez fernando-cortez commented Jan 3, 2025 •
edited
Loading

Description

Bump of the project's editor version to 6000.0.32f1 & Multiplayer Services v1.1.0.
ISession's new PlayerHasLeft callback has been used in favour of the deprecated PlayerLeft callback.

Issue Number(s)

N/A

Contribution checklist

  • [ N/A ] Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • [ N/A ] JIRA ticket ID is in the PR title or at least one commit message
  • [ N/A ] Include the ticket ID number within the body message of the PR to create a hyperlink
  • [ N/A ] An Index entry has been added in readme.md if applicable

@fernando-cortez fernando-cortez marked this pull request as ready for review January 7, 2025 18:47
@fernando-cortez fernando-cortez requested a review from a team as a code owner January 7, 2025 18:47
@fernando-cortez fernando-cortez requested a review from a team as a code owner January 13, 2025 16:31
FabianStoll
FabianStoll reviewed Jan 14, 2025
View reviewed changes
FabianStoll
FabianStoll reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@FabianStoll FabianStoll left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected , just one minor comment about the order in the changelog

@fernando-cortez fernando-cortez merged commit 7e8de47 into develop Jan 14, 2025
13 checks passed
@fernando-cortez fernando-cortez deleted the feat/6000.0.32f1-lts-upgrade branch January 14, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FabianStoll FabianStoll FabianStoll approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fernando-cortez @FabianStoll