Skip to content

fix: fixing order of components in GameObject containing a NetworkObject component [MTT-6239] #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 1, 2023
Merged

fix: fixing order of components in GameObject containing a NetworkObject component [MTT-6239] #866

merged 6 commits into from
Sep 1, 2023

Conversation

@LPLafontaineB
Copy link
Contributor

@LPLafontaineB LPLafontaineB commented Aug 28, 2023 •
edited
Loading

Description

This PR moves NetworkObject components above NetworkBehaviours in component order in networked GameObjects. This fixes a bug where during scene unloading the NetworkBehaviours would be destroyed before the NetworkObject on the host, which caused these NetworkBehaviours to not have their OnNetworkDespawned invoked in that situation on the host.

Issue Number(s)

MTT-6239

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@LPLafontaineB LPLafontaineB added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Aug 28, 2023
@LPLafontaineB LPLafontaineB marked this pull request as ready for review August 28, 2023 18:56
@LPLafontaineB LPLafontaineB requested a review from a team as a code owner August 28, 2023 18:56
RikuTheFuffs
RikuTheFuffs reviewed Aug 29, 2023
View reviewed changes
@RikuTheFuffs RikuTheFuffs self-requested a review August 29, 2023 16:53
RikuTheFuffs
RikuTheFuffs previously approved these changes Aug 29, 2023
View reviewed changes
@LPLafontaineB LPLafontaineB merged commit b13ad94 into develop Sep 1, 2023
@LPLafontaineB LPLafontaineB deleted the fix/networkbehaviours-not-despawned-on-scene-unload-on-host branch September 1, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RikuTheFuffs RikuTheFuffs RikuTheFuffs approved these changes

@noellie-velez noellie-velez Awaiting requested review from noellie-velez

Assignees

@noellie-velez noellie-velez

Labels

1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LPLafontaineB @RikuTheFuffs @noellie-velez @fernando-cortez