Skip to content

fix: clarifying additive scene synchronization fix for reconnection flow [MTT-3450] #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: v2.3.0 release
merged 7 commits into from
Sep 5, 2023
Merged

fix: clarifying additive scene synchronization fix for reconnection flow [MTT-3450] #864

merged 7 commits into from
Sep 5, 2023

Conversation

@LPLafontaineB
Copy link
Contributor

Description

This PR clarifies the fix Boss Room is using to handle clients reconnecting to the server while keeping the same active scene and having additional scenes additively loaded.

Issue Number(s)

MTT-3450

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@LPLafontaineB LPLafontaineB marked this pull request as ready for review August 24, 2023 19:34
@LPLafontaineB LPLafontaineB requested a review from a team as a code owner August 24, 2023 19:34
@LPLafontaineB LPLafontaineB added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Aug 24, 2023
NoelStephensUnity
NoelStephensUnity previously approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@NoelStephensUnity NoelStephensUnity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good LP!
Like the added comments, will help clarify that context.
Now, I just need to update the NGO documentation to reflect that same message. 😸

@LPLafontaineB LPLafontaineB merged commit 10ba2ae into develop Sep 5, 2023
@LPLafontaineB LPLafontaineB deleted the fix/additive-scene-reconnection-workaround branch September 5, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@noellie-velez noellie-velez noellie-velez approved these changes

@NoelStephensUnity NoelStephensUnity NoelStephensUnity left review comments

@RikuTheFuffs RikuTheFuffs Awaiting requested review from RikuTheFuffs

Assignees

No one assigned

Labels

1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LPLafontaineB @noellie-velez @RikuTheFuffs @NoelStephensUnity