test: update Boss Room to 2022.3.5LTS & NGO branch #852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| // Avoid throwing an exception if you are in the middle of shutting down and either | ||
| // NetworkManager no longer exists or the CustomMessagingManager no longer exists. | ||
| if (m_NetworkManager == null || m_NetworkManager.CustomMessagingManager == null) |
There was a problem hiding this comment.
Alternately, you could change this fix to:
if (m_NetworkManager == null || m_NetworkManager.ShutdownInProgress)
{
return;
}
| { | ||
| m_LobbyServiceFacade.EndTracking(); | ||
| m_ConnectionManager.NetworkManager.Shutdown(); | ||
| if (m_ConnectionManager.NetworkManager.IsListening) |
There was a problem hiding this comment.
This would be the fix for the issue with m_ShuttingDown being set to true again.
We might be able to add one more simple fix into the v1.5.2 branch if it isn't too late and then we can revert these updates.
|
Closing this PR as the 2022.3.7f1 LTS upgrade PR was already merged and an upcoming PR will address the NGO version bump. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue Number(s)
Contribution checklist