feat: adding NetworkSimulator [MTT-6084] #841
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Can change preset via dropdown
LPLafontaineB
added
the
5-Design Review
| void OnScenarioChanged(int optionIndex) | ||
| { | ||
| var scenarioName = m_ScenariosDropdown.options[optionIndex].text; | ||
| m_NetworkSimulator.Scenario = m_Scenarios.ContainsKey(scenarioName) ? m_Scenarios[scenarioName] : null; |
Contributor
There was a problem hiding this comment.
I'm easily able to reproduce an error when toggling a new scenario when ConnectionCycle scenario is already active.
Reproduction steps:
- Hit ConnectionsCycle scenario from dropdown
- While scenario is running, select another scenario from dropdown that isn't None.
- While new scenario is running, select ConnectionsCycle scenario once again.
Contributor
Author
There was a problem hiding this comment.
Coming back to this, not yet sure if this is a Tools bug, or a bad usage from my part. I'll investigate this further
Contributor
There was a problem hiding this comment.
Will re-review once more when we find out if it's on our end or not, so I'll keep this open for now.
Contributor
Author
|
Closing this and including the changes here in #843 instead to avoid conflict issues with squash and merge |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the NetworkSimulator tool to Boss Room. It can be used in the editor through the inspector, as by default, or through a new popup window which exposes some of its functionality. This window is accessible in development builds.
Issue Number(s)
MTT-6084
Contribution checklist