Skip to content

fix: decoupling SceneLoaderWrapper and ConnectionStates [MTT-6242] #830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: v2.3.0 release
merged 7 commits into from
Apr 26, 2023
Merged

fix: decoupling SceneLoaderWrapper and ConnectionStates [MTT-6242] #830

merged 7 commits into from
Apr 26, 2023

Conversation

@LPLafontaineB
Copy link
Contributor

@LPLafontaineB LPLafontaineB commented Apr 26, 2023 •
edited
Loading

Description

This PR removes SceneLoaderWrapper.AddOnSceneEventCallback and replaces it with registrations to NetworkManager OnServerStarted and OnClientStarted callbacks.

Issue Number(s)

MTT-6242

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • [n/a] An Index entry has been added in readme.md if applicable

@LPLafontaineB LPLafontaineB added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Apr 26, 2023
@LPLafontaineB LPLafontaineB marked this pull request as ready for review April 26, 2023 14:34
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Apr 26, 2023
@LPLafontaineB LPLafontaineB merged commit 32f4732 into develop Apr 26, 2023
@LPLafontaineB LPLafontaineB deleted the fix/decoupling-sceneloaderwrapper branch April 26, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@fernando-cortez fernando-cortez fernando-cortez left review comments

Assignees

@SamuelBellomo SamuelBellomo

Labels

2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LPLafontaineB @SamuelBellomo @fernando-cortez