Skip to content

refactor: replacing custom pool implementation with ObjectPool [MTT-6263] #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Apr 21, 2023
Merged

refactor: replacing custom pool implementation with ObjectPool [MTT-6263] #824

merged 14 commits into from
Apr 21, 2023

Conversation

@LPLafontaineB
Copy link
Contributor

@LPLafontaineB LPLafontaineB commented Apr 20, 2023 •
edited
Loading

Description

This PR replaces our custom pool implementation using queues with the ObjectPool collection. It also removes the methods InitializePool and ClearPool and moves their content in OnNetworkSpawn and OnNetworkDespawn

Issue Number(s)

MTT-6263 & MTT-4696

Contribution checklist

  • [n/a] Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • [n/a] An Index entry has been added in readme.md if applicable

@LPLafontaineB LPLafontaineB added 1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly labels Apr 20, 2023
@LPLafontaineB LPLafontaineB marked this pull request as ready for review April 20, 2023 20:17
LPLafontaineB
LPLafontaineB commented Apr 20, 2023
View reviewed changes
@LPLafontaineB LPLafontaineB removed the 2-Easy This PR is trivial and can be reviewed quickly label Apr 20, 2023
@LPLafontaineB LPLafontaineB merged commit 512bb55 into develop Apr 21, 2023
@LPLafontaineB LPLafontaineB deleted the fix/refactor-pool-for-native branch April 21, 2023 18:13
@LPLafontaineB LPLafontaineB mentioned this pull request Apr 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@fernando-cortez fernando-cortez Awaiting requested review from fernando-cortez

Assignees

@fernando-cortez fernando-cortez

Labels

1-Needs Review PR needs attention from the assignee and reviewers

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LPLafontaineB @SamuelBellomo @fernando-cortez