Skip to content

fix: better input sanitization [MTT-5894] #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 20, 2023
Merged

fix: better input sanitization [MTT-5894] #821

merged 4 commits into from
Apr 20, 2023

Conversation

@LPLafontaineB
Copy link
Contributor

@LPLafontaineB LPLafontaineB commented Apr 18, 2023 •
edited
Loading

Description

This PR improves how we sanitize inputs when entering IP addresses and ports. Our sanitization now prevents all invalid characters when writing in those fields, and deactivates the Join/Host button when the input cannot be parsed into a NetworkEndpoint by UnityTransport.

Issue Number(s)

MTT-5894

Contribution checklist

  • [n/a] Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • [n/a] An Index entry has been added in readme.md if applicable

@LPLafontaineB LPLafontaineB added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Apr 18, 2023
@LPLafontaineB LPLafontaineB marked this pull request as ready for review April 18, 2023 17:46
SamuelBellomo
SamuelBellomo reviewed Apr 18, 2023
View reviewed changes
SamuelBellomo
SamuelBellomo reviewed Apr 18, 2023
View reviewed changes
@LPLafontaineB LPLafontaineB merged commit 90c517f into develop Apr 20, 2023
@LPLafontaineB LPLafontaineB deleted the fix/better-input-sanitization branch April 20, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@fernando-cortez fernando-cortez Awaiting requested review from fernando-cortez

Assignees

@SamuelBellomo SamuelBellomo

Labels

1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LPLafontaineB @SamuelBellomo