Skip to content

chore: Removing (now) redundant cached NetworkBehaviour status [MTT-5239] #799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: v2.3.0 release
merged 2 commits into from
Dec 16, 2022
Merged

chore: Removing (now) redundant cached NetworkBehaviour status [MTT-5239] #799

merged 2 commits into from
Dec 16, 2022

Conversation

@fernando-cortez
Copy link
Collaborator

@fernando-cortez fernando-cortez commented Dec 16, 2022 •
edited
Loading

Description

Quick PR to remove cached NetworkBehaviour status checks that were previously allocating memory. This has since been optimized NGO-side.

Issue Number(s)

MTT-5239

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@fernando-cortez fernando-cortez added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Dec 16, 2022
@LPLafontaineB LPLafontaineB added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Dec 16, 2022
@fernando-cortez fernando-cortez merged commit 309072e into develop Dec 16, 2022
@fernando-cortez fernando-cortez deleted the chore/remove-cached-network-status branch December 16, 2022 18:02
@fernando-cortez fernando-cortez changed the title chore: Removing (now) redundant cached NetworkBehaviour status chore: Removing (now) redundant cached NetworkBehaviour status [MTT-5239] Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

+1 more reviewer

@LPLafontaineB LPLafontaineB LPLafontaineB approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LPLafontaineB LPLafontaineB

Labels

2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fernando-cortez @SamuelBellomo @LPLafontaineB