Skip to content

refactor: disconnect reason [MTT-2984] [MTT-5200] #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: chore: updating to ngo 1.2.0
merged 19 commits into from
Dec 12, 2022
Merged

refactor: disconnect reason [MTT-2984] [MTT-5200] #790

merged 19 commits into from
Dec 12, 2022

Conversation

@LPLafontaineB
Copy link
Contributor

@LPLafontaineB LPLafontaineB commented Dec 8, 2022 •
edited
Loading

Description

This PR replaces our workaround using custom messages to send a reason to clients when their approval gets denied by the host or when the host shuts down voluntarily with the DisconnectReason feature introduced in NGO 1.2.0. This PR also updates the state diagram in architecture.md to remove the DisconnectingWithReason state that is no longer necessary.

Issue Number(s)

MTT-2984 & MTT-5200

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@LPLafontaineB LPLafontaineB added the DO NOT MERGE Do not merge this PR! label Dec 8, 2022
@LPLafontaineB LPLafontaineB added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Dec 8, 2022
@LPLafontaineB
Copy link
Contributor Author

Marking this PR as DONOTMERGE until the project is updated to NGO 1.2.0

@LPLafontaineB LPLafontaineB changed the base branch from develop to chore/update-to-1.2 December 12, 2022 18:42
@LPLafontaineB LPLafontaineB marked this pull request as ready for review December 12, 2022 18:50
@LPLafontaineB LPLafontaineB removed the DO NOT MERGE Do not merge this PR! label Dec 12, 2022
SamuelBellomo
SamuelBellomo reviewed Dec 12, 2022
View reviewed changes
@LPLafontaineB LPLafontaineB merged commit 1a36c2d into chore/update-to-1.2 Dec 12, 2022
@LPLafontaineB LPLafontaineB deleted the feature/disconnect-reason branch December 12, 2022 21:15
LPLafontaineB added a commit that referenced this pull request Dec 13, 2022
@LPLafontaineB
chore: updating to ngo 1.2.0 (#791)
5821500 
* replacing custom messaging with new disconnect reason (#790)

* updating to ngo 1.2.0

* removing workaround in tests waiting two frames before disconnecting client during connection attempt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@fernando-cortez fernando-cortez Awaiting requested review from fernando-cortez

Assignees

No one assigned

Labels

1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LPLafontaineB @SamuelBellomo