Skip to content

Conversation

@SamuelBellomo
Copy link
Contributor

@SamuelBellomo SamuelBellomo commented Nov 28, 2022

Description

Bumped RNSM to 1.1.0
Switched x axis units to seconds instead of frames now that it's available. This means adjusting the sample count to a lower value as well to 30 seconds, since the x axis was moving too slowly.

Issue Number(s)

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

…ample count to a lower value now that we're using seconds and not frames.
@SamuelBellomo SamuelBellomo changed the base branch from main to develop November 28, 2022 22:55
@SamuelBellomo SamuelBellomo marked this pull request as ready for review November 28, 2022 22:58
@ian-m-unity
Copy link

ian-m-unity commented Nov 28, 2022

Minor question, is it common to store .asset files in Git LFS?

Edit: I've always thought of these as text files, but apparently some .asset files are binary 😅

@SamuelBellomo
Copy link
Contributor Author

Minor question, is it common to store .asset files in Git LFS?

@ian-m-unity in my experience, they are hard to merge, you usually want to treat them as binary. But it's true that diffs should be pretty small, so storing them in git LFS might be overkill? We didn't tweak this too much and just said binary==LFS.
It might be worth it to tweak this more for future projects, I agree.

@SamuelBellomo
Copy link
Contributor Author

Minor question, is it common to store .asset files in Git LFS?

Edit: I've always thought of these as text files, but apparently some .asset files are binary 😅

And yeah, even the text format is hard to merge anyway

@SamuelBellomo SamuelBellomo merged commit 5d41f26 into develop Dec 5, 2022
@SamuelBellomo SamuelBellomo deleted the sam/feat/bumping-RNSM-to-1.1.0 branch December 5, 2022 18:53
SamuelBellomo added a commit that referenced this pull request Dec 5, 2022
SamuelBellomo added a commit that referenced this pull request Dec 5, 2022
* Package bump and setting x axis to x per seconds. Had to change the sample count to a lower value now that we're using seconds and not frames.

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants