Skip to content

chore: ClientCharacter TODO cleanup on anticipation [MTT-1744] #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 16, 2022
Merged

chore: ClientCharacter TODO cleanup on anticipation [MTT-1744] #786

merged 6 commits into from
Dec 16, 2022

Conversation

@fernando-cortez
Copy link
Collaborator

Description

Quick PR to cleanup a TODO in code. ClientCharacter's action input anticipation chunk of code should still only execute on owning, client characters.

Issue Number(s)

MTT-1744

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@fernando-cortez fernando-cortez added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers DO NOT MERGE Do not merge this PR! labels Nov 15, 2022
@fernando-cortez fernando-cortez removed the DO NOT MERGE Do not merge this PR! label Dec 15, 2022
@fernando-cortez fernando-cortez merged commit 3b391ef into develop Dec 16, 2022
@fernando-cortez fernando-cortez deleted the chore/clientcharacter-cleanup branch December 16, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

Assignees

@SamuelBellomo SamuelBellomo

Labels

1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fernando-cortez @SamuelBellomo