Skip to content

fix: hotfix: version bump to fix android build error #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 1, 2022
Merged

fix: hotfix: version bump to fix android build error #779

merged 3 commits into from
Nov 1, 2022

Conversation

@SamuelBellomo
Copy link
Contributor

@SamuelBellomo SamuelBellomo commented Nov 1, 2022 •
edited
Loading

Description

Fixing build error on android.

Issue Number(s)

Resolves #778

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@SamuelBellomo SamuelBellomo added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Nov 1, 2022
@SamuelBellomo SamuelBellomo marked this pull request as ready for review November 1, 2022 14:53
@SamuelBellomo
Copy link
Contributor Author

Did a quick lobby run locally with mac build and editor.

fernando-cortez
fernando-cortez previously approved these changes Nov 1, 2022
View reviewed changes
@SamuelBellomo SamuelBellomo changed the title fix: hotfix: version bump to fix android compile error fix: hotfix: version bump to fix android build error Nov 1, 2022
@SamuelBellomo SamuelBellomo merged commit eeaddc0 into main Nov 1, 2022
@SamuelBellomo SamuelBellomo deleted the hotfix/fixing-android-compile-error-by-bumping-editor-version branch November 1, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fernando-cortez fernando-cortez fernando-cortez approved these changes

Assignees

No one assigned

Labels

1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Build error] When I attempt to build for Android, getting networkvariable error

2 participants

@SamuelBellomo @fernando-cortez