Skip to content

chore: replacing "template" for "sample" [MTT-5003] #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 31, 2022
Merged

chore: replacing "template" for "sample" [MTT-5003] #777

merged 3 commits into from
Oct 31, 2022

Conversation

@SamuelBellomo
Copy link
Contributor

@SamuelBellomo SamuelBellomo commented Oct 31, 2022

Description

Quick replacing words in readme

MTT-5003

Contribution checklist

  • n/a Tests have been added for boss room and/or utilities pack
  • n/a Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • n/a All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • n/a An Index entry has been added in readme.md if applicable

@SamuelBellomo SamuelBellomo added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Oct 31, 2022
fernando-cortez
fernando-cortez reviewed Oct 31, 2022
View reviewed changes
Copy link
Contributor

@fernando-cortez fernando-cortez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first section still reads:

Boss Room Sample Template is an 8-player online multiplayer co-op game showcasing Netcode for GameObjects' (Netcode) networking stack.

We could remove that here too?

@SamuelBellomo
Copy link
Contributor Author

SamuelBellomo commented Oct 31, 2022

The first section still reads:

Boss Room Sample Template is an 8-player online multiplayer co-op game showcasing Netcode for GameObjects' (Netcode) networking stack.

We could remove that here too?

@fernando-cortez woops you're right, fixed

@SamuelBellomo SamuelBellomo enabled auto-merge (squash) October 31, 2022 18:08
@fernando-cortez fernando-cortez added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Oct 31, 2022
@SamuelBellomo SamuelBellomo merged commit 0285030 into develop Oct 31, 2022
@SamuelBellomo SamuelBellomo deleted the sam/fix/replacing-template-with-sample branch October 31, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrispope chrispope Awaiting requested review from chrispope

1 more reviewer

@fernando-cortez fernando-cortez fernando-cortez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SamuelBellomo @fernando-cortez