feat: host delete lobby when shutdown [MTT-4798] [MTT-4576] #772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the behaviour of hosts regarding the Lobby service when they shutdown. Now, instead of leaving their lobby, they will delete it.
However, this makes it so clients who get disconnected afterwards will receive a LobbyNotFound error when trying to leave it. To prevent this, this PR also refactors how we handle Lobby exceptions, following the best practices outlined here. Now, instead of all being handled the same way in LobbyAPIInterface and always publishing errors, the responsibility is moved to LobbyServiceFacade. Since every call knows which errors to ignore and which ones to consider, it is each method's responsibility to determine how they handle LobbyServiceExceptions.
Issue Number(s)
MTT-4798 & MTT-4576
Contribution checklist