Skip to content

Fix: Moved Clipping Torch #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2022
Merged

Fix: Moved Clipping Torch #768

merged 3 commits into from
Oct 18, 2022

Conversation

@jilfranco-unity
Copy link
Contributor

@jilfranco-unity jilfranco-unity commented Oct 12, 2022 •
edited
Loading

Description

Moved the torch that's right next to the starting door out of the corner a bit so that the flame VFX don't clip with the wall.

I noticed too that the flame shader looks kinda crunchy and pixelated also, but I think a fix for that should come in a separate PR.

Before:
image

After:
image

Issue Number(s)

N/A, two second fix

Contribution checklist

  • Tests have been added for boss room and/or utilities pack
  • Release notes have been added to the project changelog file and/or package changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink
  • An Index entry has been added in readme.md if applicable

@jilfranco-unity
Moved the torch right next to the starting door out from the corner a…
e47deff 
… bit so that the flame VFX don't clip with the wall
@jilfranco-unity jilfranco-unity added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers labels Oct 12, 2022
@fernando-cortez fernando-cortez added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Oct 12, 2022
@jilfranco-unity jilfranco-unity mentioned this pull request Oct 14, 2022
Merged
6 tasks
SamuelBellomo
SamuelBellomo previously approved these changes Oct 14, 2022
View reviewed changes
@jilfranco-unity jilfranco-unity merged commit 564d470 into develop Oct 18, 2022
@jilfranco-unity jilfranco-unity deleted the fix/moved-clipping-torch branch October 18, 2022 13:46
SamuelBellomo added a commit that referenced this pull request Oct 20, 2022
@SamuelBellomo
Merge branch 'sam/feat/bump-NGO-to-1.1' of github.com:Unity-Technolog…
864fead 
…ies/com.unity.multiplayer.samples.coop into sam/feat/bump-NGO-to-1.1

* 'sam/feat/bump-NGO-to-1.1' of github.com:Unity-Technologies/com.unity.multiplayer.samples.coop:
  adding missing PR ID
  adding missing PR ID
  Fix: Moved Clipping Torch (#768)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SamuelBellomo SamuelBellomo SamuelBellomo approved these changes

@LPLafontaineB LPLafontaineB Awaiting requested review from LPLafontaineB

@pdeschain pdeschain Awaiting requested review from pdeschain

+1 more reviewer

@fernando-cortez fernando-cortez fernando-cortez approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

2-Easy This PR is trivial and can be reviewed quickly 2-One More Review One review in, one to go

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jilfranco-unity @SamuelBellomo @fernando-cortez