-
Notifications
You must be signed in to change notification settings - Fork 576
Uploading pull-request-template #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| <!--- | ||
| Thank you for contributing to Unity. | ||
| To help us process this pull request we recommend that you add the following information: | ||
| - Summary and list of changes in the pull request, | ||
| - Issue(s) related to the changes made such as GitHub or Jira, | ||
| - Manual testing scenarios if available | ||
| Fields marked with (*) are required. Please don't remove the template. | ||
| --> | ||
| ### Description (*) | ||
| <!--- | ||
| Please provide a description of the changes proposed in the pull request. | ||
| Letting us know what has changed and why it needed changing will help us validate this pull request. | ||
| --> | ||
| ### Related Pull Requests | ||
| <!-- related pull request placeholder --> | ||
| ### Issue Number(s) (*) | ||
| <!--- | ||
| Provide a list of fixed issues from Jira (GOMPS-ticketnumber) or GitHub (#issuenumber). | ||
| This helps us understand the reasoning behind this change, what it fixes, feature being added, etc. | ||
| --> | ||
| Fixes issue(s): | ||
| ### Manual testing scenarios | ||
| <!--- | ||
| Please provide a set of unambiguous steps to test the proposed code change. | ||
| If an error is output to either the player or editor log file, please attach. | ||
| Giving us manual testing scenarios will help with the processing and validation process. | ||
chrispope marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| --> | ||
| 1. ... | ||
| 2. ... | ||
| ### Questions or comments | ||
| <!--- | ||
| If relevant, here you can ask questions or provide comments on your pull request for the reviewer | ||
| For example if you need assistance with writing tests or would like some feedback on one of your development ideas or for the reviewer to focus on a particular area of the code. | ||
| --> | ||
| ### Contribution checklist | ||
chrispope marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| - [ ] Pull request has a meaningful description of its purpose | ||
| - [ ] All commits are accompanied by meaningful commit messages | ||
| - [ ] All new or changed code is covered with unit/integration tests (if applicable) | ||
| - [ ] All automated tests passed successfully (all builds are green) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.