Skip to content

Conversation

@FPaizSF
Copy link
Contributor

@FPaizSF FPaizSF commented Apr 1, 2021

Very safe change. just sets port # input object active to false

@FPaizSF FPaizSF assigned FPaizSF and SamuelBellomo and unassigned FPaizSF Apr 1, 2021
@SamuelBellomo SamuelBellomo added 2-Easy This PR is trivial and can be reviewed quickly 1-Needs Review PR needs attention from the assignee and reviewers 0-URGENT Blocker for a release and needs to be merged ASAP labels Apr 1, 2021
@fernando-cortez
Copy link
Contributor

I can't comment on the unity file. I strongly recommend not reusing PopupPanel prefab inside of BossRoom scene for just the "How to play" UI elements. I suggest making a new prefab instead and dropping that inside of the BossRoom scene canvas.

@SamuelBellomo
Copy link
Contributor

I can't comment on the unity file. I strongly recommend not reusing PopupPanel prefab inside of BossRoom scene for just the "How to play" UI elements. I suggest making a new prefab instead and dropping that inside of the BossRoom scene canvas.

We can discuss this further for develop. Do you have an issue with this fix for the release?

@fernando-cortez
Copy link
Contributor

Yeah, it really shouldn't be a part of this scene (it's why we saw the port image at one point here). That prefab should only be a part of the main menu scene for hosting/joining. You add components or gameobjects to that prefab and they will be reflected here as well.

This task would also just be grabbing parts of that modified prefab inside of BossRoom and ripping it out into its own prefab.

@SamuelBellomo SamuelBellomo merged commit 70c1ccb into release/v0.1.0-experimental Apr 1, 2021
@SamuelBellomo SamuelBellomo deleted the bugfix/hidePortInHelp branch April 1, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-URGENT Blocker for a release and needs to be merged ASAP 1-Needs Review PR needs attention from the assignee and reviewers 2-Easy This PR is trivial and can be reviewed quickly

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants