Feature/region support #234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamuelBellomo
added
the
1-Needs Review
LukeStampfli
commented
Mar 30, 2021
| } | ||
| } | ||
|
|
||
| void Update() |
Contributor
Author
There was a problem hiding this comment.
This stuff only exists because our connection management is broken. (We don't wait for the socket task returned by MLAPI to complete but jump to the character select scene immediately)
SamuelBellomo
added
the
0-URGENT
…o feature/region-support # Conflicts: # Packages/manifest.json # Packages/packages-lock.json
SamuelBellomo
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following
The reason why there is no room key preview anymore is because for that we would have to do an async operation which takes a few second to find the best connect region and then override the UI panel with the right value. It would introduce 100 LoC and the user experience wouldn't be great so I cut that feature.