Bug fix: hide icons for unimplemented attacks #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes earlier temp code that hard-coded separate sprite lists per class. Now uses the Sprites assigned in the GameDataSource. If a class has an unimplemented skill (or the skill has no assigned Sprite), the button for that skill is hidden.
SamuelBellomo
added
0-URGENT
SamuelBellomo
approved these changes
Mar 29, 2021
fernando-cortez
approved these changes
Mar 29, 2021
fernando-cortez
added
3-Good to Merge
and removed
1-Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes earlier temporary code that hard-coded separate sprite lists per class. it now uses the Sprites assigned in the
GameDataSource. If a hero's class has an unimplemented skill (or the skill has no assigned Sprite), the button for that skill is hidden.I'm not sure if this has a new bug number or not. This was originally [GOMPS-347] and [GOMPS-348], "wizard Freeze button doesn't work" and "rogue Dash button doesn't work". For this release milestone, the fix to those bugs is to make those buttons go away. The most elegant way to do that was just to remove the crufty code from
HeroActionBarso that it would correctly represent the GameDataSource data.