Skip to content

Feature/parenting for animation-triggered FX #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2021
Merged

Feature/parenting for animation-triggered FX #185

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8df74c7
Feature/parenting for animation-triggered FX
eheimburg Mar 18, 2021
6bba6a0
tweaked a comment
eheimburg Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions Assets/BossRoom/Scripts/Client/AnimationCallbacks/AnimatorTriggeredSpecialFX.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ internal class AnimatorNodeEntryEvent
public float m_PrefabSpawnDelaySeconds;
[Tooltip("If we leave the AnimationNode, should we shutdown the fx or let it play out? 0 = never cancel. Any other time = we can cancel up until this amount of time has elapsed... after that, we just let it play out. So a really big value like 9999 effectively means 'always cancel'")]
public float m_PrefabCanBeAbortedUntilSecs;
[Tooltip("If the particle should be parented to a specific bone, link that bone here. (If null, plays at character's feet.)")]
public Transform m_PrefabParent;
[Tooltip("Prefab will be spawned with this local offset from the parent (Remember, it's a LOCAL offset, so it's affected by the parent transform's scale and rotation!)")]
public Vector3 m_PrefabParentOffset;

[Header("Sound Effect")]
[Tooltip("If we want to use a sound effect that's not in the prefab, specify it here")]
Expand Down Expand Up @@ -65,6 +69,10 @@ internal class AnimatorNodeExitEvent
public SpecialFXGraphic m_Prefab;
[Tooltip("Wait this many seconds before instantiating the Prefab.")]
public float m_PrefabStartDelaySeconds;
[Tooltip("If the particle should be parented to a specific bone, link that bone here. (By default, plays at character's feet.)")]
public Transform m_PrefabParent;
[Tooltip("Prefab will be spawned with this local offset from the parent (Remember, it's a LOCAL offset, so it's affected by the parent transform's scale and rotation!)")]
public Vector3 m_PrefabParentOffset;

[Header("Sound Effect")]
[Tooltip("If we want to use a sound effect that's not in the prefab, specify it here")]
Expand Down Expand Up @@ -137,7 +145,9 @@ private IEnumerator CoroPlayStateEnterFX(AnimatorNodeEntryEvent eventInfo)
if (!m_ActiveNodes.Contains(eventInfo.m_AnimatorNodeNameHash))
yield break;

var instantiatedFX = Instantiate(eventInfo.m_Prefab, m_Animator.transform);
Transform parent = eventInfo.m_PrefabParent != null ? eventInfo.m_PrefabParent : m_Animator.transform;
var instantiatedFX = Instantiate(eventInfo.m_Prefab, parent);
instantiatedFX.transform.localPosition += eventInfo.m_PrefabParentOffset;

// now we just need to watch and see if we end up needing to prematurely end these new graphics
if (eventInfo.m_PrefabCanBeAbortedUntilSecs > 0)
Expand Down Expand Up @@ -233,7 +243,9 @@ private IEnumerator CoroPlayStateExitFX(AnimatorNodeExitEvent eventInfo)
if (eventInfo.m_PrefabStartDelaySeconds > 0)
yield return new WaitForSeconds(eventInfo.m_PrefabStartDelaySeconds);

Instantiate(eventInfo.m_Prefab, m_Animator.transform);
Transform parent = eventInfo.m_PrefabParent != null ? eventInfo.m_PrefabParent : m_Animator.transform;
var instantiatedFX = Instantiate(eventInfo.m_Prefab, parent);
instantiatedFX.transform.localPosition += eventInfo.m_PrefabParentOffset;
}

// plays the sound effect of an on-exit event
Expand Down