Skip to content

Conversation

@pdeschain
Copy link
Contributor

the text is directly copied from Git documentation over here: https://git-scm.com/book/en/v2/Customizing-Git-Git-Configuration

@pdeschain pdeschain added the 2-Easy This PR is trivial and can be reviewed quickly label Mar 15, 2021
@pdeschain pdeschain changed the base branch from master to develop March 15, 2021 21:32
@pdeschain pdeschain added the 1-Needs Review PR needs attention from the assignee and reviewers label Mar 15, 2021
@SamuelBellomo
Copy link
Contributor

You should include the source in the readme directly.
Also, this PR should be against release, not develop

@pdeschain pdeschain changed the base branch from develop to release/v0.1.0-experimental March 15, 2021 21:35
lkrell
lkrell previously approved these changes Mar 16, 2021
Copy link
Contributor

@lkrell lkrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make that slight documentation tweak, and good to go from docs side.

lkrell
lkrell previously approved these changes Mar 17, 2021
Copy link
Contributor

@lkrell lkrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from docs side!

@pdeschain pdeschain force-pushed the feature/line-endings-guidance-for-contributors branch from b017375 to 7cd1795 Compare March 17, 2021 19:32
@pdeschain pdeschain requested a review from lkrell March 17, 2021 19:32
@pdeschain pdeschain added 2-One More Review One review in, one to go and removed 1-Needs Review PR needs attention from the assignee and reviewers labels Mar 17, 2021
@pdeschain pdeschain merged commit 42f0ebf into release/v0.1.0-experimental Mar 17, 2021
@pdeschain pdeschain deleted the feature/line-endings-guidance-for-contributors branch March 17, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2-Easy This PR is trivial and can be reviewed quickly 2-One More Review One review in, one to go

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants