Skip to content

Conversation

@ArturoNereu
Copy link
Contributor

Changed the URL to the readme as the current version generates a broken link.

Changed the URL to the readme as the current version generates a broken link.
@ArturoNereu ArturoNereu added the 2-Easy This PR is trivial and can be reviewed quickly label Mar 8, 2021
SamuelBellomo
SamuelBellomo previously approved these changes Mar 8, 2021
@SamuelBellomo SamuelBellomo changed the base branch from master to develop March 8, 2021 19:03
@SamuelBellomo SamuelBellomo dismissed their stale review March 8, 2021 19:03

The base branch was changed.

Copy link
Contributor

@SamuelBellomo SamuelBellomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please create a PR against develop, not master

Copy link
Contributor Author

@ArturoNereu ArturoNereu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switched to develop to merge to

@SamuelBellomo SamuelBellomo added the 0-URGENT Blocker for a release and needs to be merged ASAP label Mar 9, 2021
@SamuelBellomo
Copy link
Contributor

can you make sure your diff only includes your changes please?

@SamuelBellomo SamuelBellomo added the 1-Needs Review PR needs attention from the assignee and reviewers label Mar 10, 2021
pdeschain
pdeschain previously approved these changes Mar 10, 2021
```

Please check out [CONTRIBUTING.md](CONTRIBUTING.md) for guidelines on submitting issues and PRs to BossRoom!
Please check out [CONTRIBUTING.md](CONTRIBUTING.md) for guidelines on submitting issues and PRs to BossRoom!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should .md be removed here too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, the .md removal is so it points to the right file

@pdeschain pdeschain added the 2-One More Review One review in, one to go label Mar 10, 2021
@SamuelBellomo SamuelBellomo changed the base branch from develop to master March 10, 2021 22:06
@SamuelBellomo SamuelBellomo dismissed pdeschain’s stale review March 10, 2021 22:06

The base branch was changed.

@pdeschain pdeschain added 3-Good to Merge and removed 1-Needs Review PR needs attention from the assignee and reviewers 2-One More Review One review in, one to go labels Mar 10, 2021
@SamuelBellomo SamuelBellomo merged commit a94f6e5 into master Mar 10, 2021
@SamuelBellomo SamuelBellomo deleted the license-link-fix branch March 10, 2021 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0-URGENT Blocker for a release and needs to be merged ASAP 2-Easy This PR is trivial and can be reviewed quickly 3-Good to Merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants