Feat: Client Driven UI Art #69
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…haracter-controller-assets
…t/third-person-character-controller-integration
…haracter-controller-assets
…t/third-person-character-controller-integration
…I' into feat/client-driven-ui-art
…t disabled on out of focus devices)
…I' into feat/client-driven-ui-art
fernando-cortez
approved these changes
Dec 6, 2022
Base automatically changed from
feat/third-person-character-controller-integration-IP-UI
to
develop
December 6, 2022 19:43
# Conflicts: # Basic/ClientDriven/Assets/Scripts/ServerPlayerMove.cs # Basic/ClientDriven/Assets/UI Toolkit/ClientDrivenUIStyleSheet.uss # Basic/ClientDriven/Assets/UI Toolkit/GameUI/GameUI.uxml # Basic/ClientDriven/Assets/UI Toolkit/GameUI/MainMenuUI.uxml # Basic/ClientDriven/Packages/manifest.json # Basic/ClientDriven/Packages/packages-lock.json
fernando-cortez
approved these changes
Dec 6, 2022
|
Maybe the in-game UI could have backdrop images so the text can always be readable against the environment. The text can be difficult to read when it is overlay throughout the level. |
|
I agree a background would be helpful! We're trying to get this PR into develop so we can playtest it before the release though--maybe this is something we can add post release? @chrispope |
|
Yes, certainly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for the UI pass of the client driven sample! We've taken the UI toolkit UI from the 2D Space Shooter sample and reskinned it to match with the art style of this sample. I figure too that we can reuse this version because it's a lot more clean cut and simple--we can just edit the colors to match other samples that we make in the future.
Here are the before and after shots (which are shown with the new art merged in locally so you can see how it looks with it):
Before:
After:
