-
Notifications
You must be signed in to change notification settings - Fork 136
feat: distributed authority sample - in-editor tutorial session owner promotion [MTT-9361] #268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: distributed authority sample - in-editor tutorial session owner promotion [MTT-9361] #268
Conversation
…ple tutorial outlined
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First batch
Basic/DistributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial Welcome Page.asset
Outdated
Show resolved
Hide resolved
Basic/DistributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial Welcome Page.asset
Outdated
Show resolved
Hide resolved
...cialHub/Assets/Editor/Tutorials/Tutorial2_SetupNetSceneVis/8-Multiplayer Tooling Ready.asset
Outdated
Show resolved
Hide resolved
.../Assets/Editor/Tutorials/Tutorial2_SetupNetSceneVis/2-Open Network Scene Visualization.asset
Outdated
Show resolved
Hide resolved
.../Assets/Editor/Tutorials/Tutorial2_SetupNetSceneVis/2-Open Network Scene Visualization.asset
Outdated
Show resolved
Hide resolved
...edAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/1-Verify And Setup UGS.asset
Outdated
Show resolved
Hide resolved
...edAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/1-Verify And Setup UGS.asset
Outdated
Show resolved
Hide resolved
...edAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/1-Verify And Setup UGS.asset
Outdated
Show resolved
Hide resolved
...edAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/1-Verify And Setup UGS.asset
Outdated
Show resolved
Hide resolved
...edAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/1-Verify And Setup UGS.asset
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed CheckServices.asset
...stributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/2-CheckServices.asset
Outdated
Show resolved
Hide resolved
...stributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/2-CheckServices.asset
Outdated
Show resolved
Hide resolved
...stributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/2-CheckServices.asset
Outdated
Show resolved
Hide resolved
...stributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/2-CheckServices.asset
Outdated
Show resolved
Hide resolved
...stributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/2-CheckServices.asset
Outdated
Show resolved
Hide resolved
...stributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/2-CheckServices.asset
Outdated
Show resolved
Hide resolved
...stributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/2-CheckServices.asset
Outdated
Show resolved
Hide resolved
...stributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/2-CheckServices.asset
Outdated
Show resolved
Hide resolved
...stributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/2-CheckServices.asset
Outdated
Show resolved
Hide resolved
...stributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/2-CheckServices.asset
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed CheckVivox.asset
.../DistributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/3-CheckVivox.asset
Outdated
Show resolved
Hide resolved
.../DistributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/3-CheckVivox.asset
Outdated
Show resolved
Hide resolved
.../DistributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/3-CheckVivox.asset
Outdated
Show resolved
Hide resolved
.../DistributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/3-CheckVivox.asset
Outdated
Show resolved
Hide resolved
.../DistributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/3-CheckVivox.asset
Outdated
Show resolved
Hide resolved
.../DistributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/3-CheckVivox.asset
Outdated
Show resolved
Hide resolved
.../DistributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/3-CheckVivox.asset
Outdated
Show resolved
Hide resolved
.../DistributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/3-CheckVivox.asset
Outdated
Show resolved
Hide resolved
.../DistributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/3-CheckVivox.asset
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second batch
...ritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/8-Project Successfully Linked.asset
Outdated
Show resolved
Hide resolved
...ritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/8-Project Successfully Linked.asset
Outdated
Show resolved
Hide resolved
...ritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/8-Project Successfully Linked.asset
Outdated
Show resolved
Hide resolved
...ritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/8-Project Successfully Linked.asset
Outdated
Show resolved
Hide resolved
...ritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/8-Project Successfully Linked.asset
Outdated
Show resolved
Hide resolved
...tor/Tutorials/Tutorial1_SetupMultiplayerPlayMode/8-Virtual Player Successfully Created.asset
Outdated
Show resolved
Hide resolved
...tor/Tutorials/Tutorial1_SetupMultiplayerPlayMode/8-Virtual Player Successfully Created.asset
Outdated
Show resolved
Hide resolved
...tor/Tutorials/Tutorial1_SetupMultiplayerPlayMode/8-Virtual Player Successfully Created.asset
Outdated
Show resolved
Hide resolved
...tor/Tutorials/Tutorial1_SetupMultiplayerPlayMode/8-Virtual Player Successfully Created.asset
Outdated
Show resolved
Hide resolved
...tor/Tutorials/Tutorial1_SetupMultiplayerPlayMode/8-Virtual Player Successfully Created.asset
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Third batch
...SocialHub/Assets/Editor/Tutorials/Tutorial2_SetupNetSceneVis/1-Setup Multiplayer Tools.asset
Outdated
Show resolved
Hide resolved
...SocialHub/Assets/Editor/Tutorials/Tutorial2_SetupNetSceneVis/1-Setup Multiplayer Tools.asset
Outdated
Show resolved
Hide resolved
...SocialHub/Assets/Editor/Tutorials/Tutorial2_SetupNetSceneVis/1-Setup Multiplayer Tools.asset
Outdated
Show resolved
Hide resolved
...SocialHub/Assets/Editor/Tutorials/Tutorial2_SetupNetSceneVis/1-Setup Multiplayer Tools.asset
Outdated
Show resolved
Hide resolved
...SocialHub/Assets/Editor/Tutorials/Tutorial2_SetupNetSceneVis/1-Setup Multiplayer Tools.asset
Outdated
Show resolved
Hide resolved
...ialHub/Assets/Editor/Tutorials/Tutorial3_SessionOwnerPromotion/1-SessionOwnerPromotion.asset
Outdated
Show resolved
Hide resolved
...ialHub/Assets/Editor/Tutorials/Tutorial3_SessionOwnerPromotion/1-SessionOwnerPromotion.asset
Outdated
Show resolved
Hide resolved
...ialHub/Assets/Editor/Tutorials/Tutorial3_SessionOwnerPromotion/1-SessionOwnerPromotion.asset
Outdated
Show resolved
Hide resolved
...ialHub/Assets/Editor/Tutorials/Tutorial3_SessionOwnerPromotion/1-SessionOwnerPromotion.asset
Outdated
Show resolved
Hide resolved
...ialHub/Assets/Editor/Tutorials/Tutorial3_SessionOwnerPromotion/1-SessionOwnerPromotion.asset
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final batch!
.../Assets/Editor/Tutorials/Tutorial3_SessionOwnerPromotion/8-LeaveSessionAsVirtualPlayer.asset
Outdated
Show resolved
Hide resolved
.../Assets/Editor/Tutorials/Tutorial3_SessionOwnerPromotion/8-LeaveSessionAsVirtualPlayer.asset
Outdated
Show resolved
Hide resolved
.../Assets/Editor/Tutorials/Tutorial3_SessionOwnerPromotion/8-LeaveSessionAsVirtualPlayer.asset
Outdated
Show resolved
Hide resolved
.../Assets/Editor/Tutorials/Tutorial3_SessionOwnerPromotion/8-LeaveSessionAsVirtualPlayer.asset
Outdated
Show resolved
Hide resolved
.../Assets/Editor/Tutorials/Tutorial3_SessionOwnerPromotion/8-LeaveSessionAsVirtualPlayer.asset
Outdated
Show resolved
Hide resolved
...ditor/Tutorials/Tutorial3_SessionOwnerPromotion/10-Session Owner Successfully Promoted.asset
Outdated
Show resolved
Hide resolved
...ditor/Tutorials/Tutorial3_SessionOwnerPromotion/10-Session Owner Successfully Promoted.asset
Outdated
Show resolved
Hide resolved
...ditor/Tutorials/Tutorial3_SessionOwnerPromotion/10-Session Owner Successfully Promoted.asset
Outdated
Show resolved
Hide resolved
...ditor/Tutorials/Tutorial3_SessionOwnerPromotion/10-Session Owner Successfully Promoted.asset
Outdated
Show resolved
Hide resolved
...ditor/Tutorials/Tutorial3_SessionOwnerPromotion/10-Session Owner Successfully Promoted.asset
Outdated
Show resolved
Hide resolved
…torial Welcome Page.asset Co-authored-by: Vic Cooper <[email protected]>
…torial Welcome Page.asset Co-authored-by: Vic Cooper <[email protected]>
…torial2_SetupNetSceneVis/8-Multiplayer Tooling Ready.asset Co-authored-by: Vic Cooper <[email protected]>
…torial2_SetupNetSceneVis/2-Open Network Scene Visualization.asset Co-authored-by: Vic Cooper <[email protected]>
…torial2_SetupNetSceneVis/2-Open Network Scene Visualization.asset Co-authored-by: Vic Cooper <[email protected]>
…torial2_SetupNetSceneVis/2-Open Network Scene Visualization.asset Co-authored-by: Vic Cooper <[email protected]>
…torial2_SetupNetSceneVis/2-Open Network Scene Visualization.asset Co-authored-by: Vic Cooper <[email protected]>
…torial2_SetupNetSceneVis/2-Open Network Scene Visualization.asset Co-authored-by: Vic Cooper <[email protected]>
…torial2_SetupNetSceneVis/2-Open Network Scene Visualization.asset Co-authored-by: Vic Cooper <[email protected]>
…torial2_SetupNetSceneVis/2-Open Network Scene Visualization.asset Co-authored-by: Vic Cooper <[email protected]>
…torial2_SetupNetSceneVis/4-Validate Network Scene Visualization.asset Co-authored-by: Vic Cooper <[email protected]>
…torial2_SetupNetSceneVis/4-Validate Network Scene Visualization.asset Co-authored-by: Vic Cooper <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one thing, the tutorials seem to be completed already when checking out. After addressing approved from my side
Statuses can be cleared locally if you select Tutorials/Authoring/Debug/Progress Tracking/Clear All Statuses
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The background colors of the 3rd and 4tf of these makes the text in these hard to read for me:

The copy of the welcome dialog could be written in a better way. The first sentence feels like it's missing a "." after "topology", and it assumes that the users knows what you're talking about.
Also, there are guidelines about never saying "user" in user-facing copy. Did design and product have a look at this? cc @danni-lu @hershbansal99

...edAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/1-Verify And Setup UGS.asset
Outdated
Show resolved
Hide resolved
...stributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/2-CheckServices.asset
Show resolved
Hide resolved
...stributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/2-CheckServices.asset
Show resolved
Hide resolved
.../DistributedAuthoritySocialHub/Assets/Editor/Tutorials/Tutorial0_SetupUGS/3-CheckVivox.asset
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a good reason to have 4 tutorial categories with just 1 tutorial in each of them?
These could just be 1 category with 4 tutorials in it. it'd free up 3 rows in the table of content, making it easier to see the links at the bottom of the ToC (which are currently hidden unless you scroll, because of this).
It's also easier for users to see all relevant tutorials at once, instead of going in and out of each category.
Are the images ship-blocking? They feel fine to me and we can always adjust the darkness another time. |
Filtering of content, mostly. Also, in the future as we start to build out more IETs, we can use these as the buckets for those types of tutorials, since they're all unrelated to one another. |
No.
Did they do with official IET copy and formatting guidelines in mind? Maybe they were unaware of them, because they don't seem to be implemented in the 1st tutorial, nor in the welcome dialog's copy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that the Vivox setup is now broken (details here: #268 (comment) )
Fixed! Good spot. |





Description
This PR adds a total of 4 tutorials to Distributed Authority Social Hub. They are:
Note: the tutorial step that validates if a virtual player is enabled is not yet complete, but for now that condition will step through the tutorial assuming that a player is active. This will be updated in a future commit.
Issue Number(s)
MTT-9361
Contribution checklist