Skip to content

Conversation

@fernando-cortez
Copy link
Contributor

@fernando-cortez fernando-cortez commented Dec 13, 2024

Description

This PR adds a total of 4 tutorials to Distributed Authority Social Hub. They are:

  • UGS setup (linking your project with a cloud project id)
  • Multiplayer Play Mode Setup (create a virtual player)
  • Network Scene Visualization Setup (go from multiplayer tools window to the scene and toggle toolbar)
  • Session Owner Promotion (start game with a virtual player, create a session, make session owner disconnect)

Note: the tutorial step that validates if a virtual player is enabled is not yet complete, but for now that condition will step through the tutorial assuming that a player is active. This will be updated in a future commit.

Issue Number(s)

MTT-9361

Contribution checklist

  • [ N/A ] Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@hammerlerobi hammerlerobi self-assigned this Dec 16, 2024
@Vic-Cooper Vic-Cooper self-requested a review December 16, 2024 13:06
Copy link
Contributor

@Vic-Cooper Vic-Cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First batch

Copy link
Contributor

@Vic-Cooper Vic-Cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed CheckServices.asset

Copy link
Contributor

@Vic-Cooper Vic-Cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed CheckVivox.asset

Copy link
Contributor

@Vic-Cooper Vic-Cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second batch

Copy link
Contributor

@Vic-Cooper Vic-Cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Third batch

Copy link
Contributor

@Vic-Cooper Vic-Cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final batch!

fernando-cortez and others added 13 commits December 16, 2024 15:41
…torial2_SetupNetSceneVis/8-Multiplayer Tooling Ready.asset

Co-authored-by: Vic Cooper <[email protected]>
…torial2_SetupNetSceneVis/2-Open Network Scene Visualization.asset

Co-authored-by: Vic Cooper <[email protected]>
…torial2_SetupNetSceneVis/2-Open Network Scene Visualization.asset

Co-authored-by: Vic Cooper <[email protected]>
…torial2_SetupNetSceneVis/2-Open Network Scene Visualization.asset

Co-authored-by: Vic Cooper <[email protected]>
…torial2_SetupNetSceneVis/2-Open Network Scene Visualization.asset

Co-authored-by: Vic Cooper <[email protected]>
…torial2_SetupNetSceneVis/2-Open Network Scene Visualization.asset

Co-authored-by: Vic Cooper <[email protected]>
…torial2_SetupNetSceneVis/2-Open Network Scene Visualization.asset

Co-authored-by: Vic Cooper <[email protected]>
…torial2_SetupNetSceneVis/2-Open Network Scene Visualization.asset

Co-authored-by: Vic Cooper <[email protected]>
…torial2_SetupNetSceneVis/4-Validate Network Scene Visualization.asset

Co-authored-by: Vic Cooper <[email protected]>
…torial2_SetupNetSceneVis/4-Validate Network Scene Visualization.asset

Co-authored-by: Vic Cooper <[email protected]>
Copy link
Contributor

@hammerlerobi hammerlerobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one thing, the tutorials seem to be completed already when checking out. After addressing approved from my side

@fernando-cortez fernando-cortez dismissed stale reviews from hammerlerobi and Vic-Cooper December 20, 2024 16:53

Statuses can be cleared locally if you select Tutorials/Authoring/Debug/Progress Tracking/Clear All Statuses

@RikuTheFuffs RikuTheFuffs self-requested a review December 20, 2024 17:29
Copy link
Contributor

@RikuTheFuffs RikuTheFuffs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The background colors of the 3rd and 4tf of these makes the text in these hard to read for me:
image

The copy of the welcome dialog could be written in a better way. The first sentence feels like it's missing a "." after "topology", and it assumes that the users knows what you're talking about.
Also, there are guidelines about never saying "user" in user-facing copy. Did design and product have a look at this? cc @danni-lu @hershbansal99
image

Copy link
Contributor

@RikuTheFuffs RikuTheFuffs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a good reason to have 4 tutorial categories with just 1 tutorial in each of them?
These could just be 1 category with 4 tutorials in it. it'd free up 3 rows in the table of content, making it easier to see the links at the bottom of the ToC (which are currently hidden unless you scroll, because of this).

It's also easier for users to see all relevant tutorials at once, instead of going in and out of each category.

image

@fernando-cortez
Copy link
Contributor Author

The background colors of the 3rd and 4tf of these makes the text in these hard to read for me: image

The copy of the welcome dialog could be written in a better way. The first sentence feels like it's missing a "." after "topology", and it assumes that the users knows what you're talking about. Also, there are guidelines about never saying "user" in user-facing copy. Did design and product have a look at this? cc @danni-lu @hershbansal99 image

Are the images ship-blocking? They feel fine to me and we can always adjust the darkness another time.
Yes, Vic has done a pass over all of the text inside the tutorials, so I'll defer to what they've suggested here, and in the rest of the tutorials. We can also just replace user with anyone, if that works.

@fernando-cortez
Copy link
Contributor Author

Is there a good reason to have 4 tutorial categories with just 1 tutorial in each of them? These could just be 1 category with 4 tutorials in it. it'd free up 3 rows in the table of content, making it easier to see the links at the bottom of the ToC (which are currently hidden unless you scroll, because of this).

It's also easier for users to see all relevant tutorials at once, instead of going in and out of each category.

image

Filtering of content, mostly. Also, in the future as we start to build out more IETs, we can use these as the buckets for those types of tutorials, since they're all unrelated to one another.

@danni-lu
Copy link

I did a quick contrast check on 3rd and 4th image. It seems the lighter area is a little promblematic. I would recommend adding a little overlay to the image to make it darker.
image

@RikuTheFuffs
Copy link
Contributor

Are the images ship-blocking?

No.

Vic has done a pass over all of the text inside the tutorials, so I'll defer to what they've suggested here, and in the rest of the tutorials. We can also just replace user with anyone, if that works.

Did they do with official IET copy and formatting guidelines in mind? Maybe they were unaware of them, because they don't seem to be implemented in the 1st tutorial, nor in the welcome dialog's copy.

@RikuTheFuffs RikuTheFuffs self-requested a review December 20, 2024 20:27
Copy link
Contributor

@RikuTheFuffs RikuTheFuffs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that the Vivox setup is now broken (details here: #268 (comment) )

@RikuTheFuffs RikuTheFuffs self-requested a review December 20, 2024 20:51
@fernando-cortez
Copy link
Contributor Author

Seems that the Vivox setup is now broken (details here: #268 (comment) )

Fixed! Good spot.

@fernando-cortez fernando-cortez merged commit bb8f319 into develop Dec 20, 2024
29 checks passed
@fernando-cortez fernando-cortez deleted the feat/distributed-authority-sample/in-editor-tutorial-session-owner-promotion branch December 20, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants