[MTT-9279] Fix: Distributed Authority Sample Lighting, Shadow and Shader Fixes #265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rebaked lightmaps - Commented some keywords in Assets/Shaders/CustomHLSL/CustomLighting.hlsl for shadows - Added _MAIN_LIGHT_SHADOWS keyword to Assets/Shaders/SubGraphs/ToonShading.shadersubgraph - Switched keywords to "Multi Compile" instead of "Shader Feature" in Assets/Shaders/SubGraphs/ToonLightingModel.shadersubgraph - Switched the directional light mode to Mixed from Baked in the TownMarket scene
- Set main light cascade settings to match original project
…enabling opaque and depth texture settings in RPAssets
|
|
…ting-shadow-and-water-fix
hammerlerobi
previously approved these changes
Dec 9, 2024
fernando-cortez
previously approved these changes
Dec 10, 2024
…ting-shadow-and-water-fix
Elfi0Kuhndorf
dismissed stale reviews from fernando-cortez and hammerlerobi
via
dbfa22f
Elfi0Kuhndorf
deleted the
fix/distributed-authority-sample/cal-lighting-shadow-and-water-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cal Chiu helped our team and adjusted settings and shader to fix the lighting and shadow display within the project. Further with the help of MingWai we fixed the transparency issue of the water. This PR helps to improve the overall look of the sample.
Issue Number(s)
https://jira.unity3d.com/browse/MTT-9279
Contribution checklist