Skip to content

Conversation

@Elfi0Kuhndorf
Copy link
Contributor

@Elfi0Kuhndorf Elfi0Kuhndorf commented Sep 18, 2024

Description

This PR adds a UI Design for the Main Menu scene. The original Chop Chop main menu scene got imported and modified (colliders removed, some positions changed and some assets removed). Also the UITK sample main menu UI got imported and modified.
Functionality for Servicehelper.cs and MainMenuView.cs got adjusted to handle connection logic.

How to test:
Open Bootstrap scene and press play (after connecting Vivox in project settings to a valid project id).
Check that entering Player name, Session name and pressing Start button in Main Menu work as expected.

Considerations:
We might want to monitor which kind of player names people can enter (see: https://unity.slack.com/archives/C023C5V8P9S/p1726586223121339)

Issue Number(s)

https://jira.unity3d.com/browse/MTT-8894

Contribution checklist

  • Tests have been added for the project and/or any internal package
  • Release notes have been added to the project changelog file
  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • JIRA ticket ID is in the PR title or at least one commit message
  • Include the ticket ID number within the body message of the PR to create a hyperlink

@Elfi0Kuhndorf Elfi0Kuhndorf requested a review from a team as a code owner September 18, 2024 11:45
Copy link
Contributor

@hammerlerobi hammerlerobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working as expected

@fernando-cortez fernando-cortez merged commit a360aa6 into develop Oct 10, 2024
2 checks passed
@fernando-cortez fernando-cortez deleted the feat/distributed-authority-sample/main-menu-ui branch October 10, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants